chrome/browser/extensions/api/media_galleries/media_galleries_api.cc - Issue 15624003: Validate image files before writing them to media galleries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

Issue 15624003: Validate image files before writing them to media galleries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/media_galleries/OWNERS » ('j') | chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

diff --git a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

index 194fe0c6d0772d182bd90eb4cb7b32ad67878880..9e4b5b3e5f113691fc187a185017796c0bfa2531 100644

--- a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

+++ b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

@@ -186,6 +186,7 @@ void MediaGalleriesGetMediaFileSystemsFunction::ReturnGalleries(

if (!policy->CanReadFile(child_id, filesystems[i].path))

policy->GrantReadFile(child_id, filesystems[i].path);

policy->GrantReadFileSystem(child_id, filesystems[i].fsid);

+policy->GrantCreateFileForFileSystem(child_id, filesystems[i].fsid);

Greg Billock 2013/05/22 16:21:59 whitespace. But does this need to get gated by "if

vandebo (ex-Chrome) 2013/05/22 18:41:17 Oops, this is only for debugging. There are anoth

}

« no previous file with comments | « no previous file | chrome/browser/media_galleries/OWNERS » ('j') | chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.cc » ('J')