Validate image files before writing them to media galleries.

chrome/browser/media_galleries/fileapi/media_file_validator_unittest.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/basictypes.h"
+#include "base/bind.h"
+#include "base/file_util.h"
+#include "base/files/file_path.h"
+#include "base/files/scoped_temp_dir.h"
+#include "base/message_loop.h"
+#include "chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "content/public/test/browser_test.h"
+#include "content/public/test/test_utils.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "webkit/browser/fileapi/copy_or_move_file_validator.h"
+#include "webkit/browser/fileapi/file_system_context.h"
+#include "webkit/browser/fileapi/file_system_mount_point_provider.h"
+#include "webkit/browser/fileapi/file_system_operation.h"
+#include "webkit/browser/fileapi/file_system_url.h"
+#include "webkit/browser/fileapi/isolated_context.h"
+#include "webkit/browser/fileapi/mock_file_system_context.h"
+#include "webkit/browser/fileapi/test_mount_point_provider.h"
+#include "webkit/common/fileapi/file_system_types.h"
+
+namespace {
+
+const char kOrigin[] = "http://foo";
+
+const char kValidImage[] = "RIFF0\0\0\0WEBPVP8 $\0\0\0\xB2\x02\0\x9D\x01\x2A"
+                           "\x01\0\x01\0\x2F\x9D\xCE\xE7s\xA8((((\x01\x9CK(\0"
+                           "\x05\xCE\xB3l\0\0\xFE\xD8\x80\0\0";
+
+const char kInvalidImage[] = "Not an image";
+
+const int64 kNoFileSize = -1;
+
+void HandleCheckFileResult(int64 expected_size,
+                           const base::Callback<void(bool success)>& callback,
+                           base::PlatformFileError result,
+                           const base::PlatformFileInfo& file_info,
+                           const base::FilePath& /*platform_path*/) {
+  if (result == base::PLATFORM_FILE_OK) {
+    if (!file_info.is_directory && expected_size != kNoFileSize &&
+        file_info.size == expected_size) {
+      callback.Run(true);
+      return;
+    }
+  } else {
+    if (expected_size == kNoFileSize) {
+      callback.Run(true);
+      return;
+    }
+  }
+  callback.Run(false);
+}
+
+}  // namespace
+
+namespace chrome {
+
+class MediaFileValidatorTest : public InProcessBrowserTest {
+ public:
+  MediaFileValidatorTest() : test_file_size_(0) {}
+
+  virtual ~MediaFileValidatorTest() {}
+
+  // Write |content| into |filename| in a test file system and try to move
+  // it into a media file system.  The result is compared to |exepcted_result|.

[Lei Zhang, 2013/05/29 09:40:58]

typo

[vandebo (ex-Chrome), 2013/05/29 18:56:05]

Done.

+  void MoveTest(const std::string& filename, const std::string& content,
+                bool expected_result) {
+    content::BrowserThread::PostTask(
+        content::BrowserThread::FILE,
+        FROM_HERE,
+        base::Bind(&MediaFileValidatorTest::SetupOnFileThread,
+                   base::Unretained(this), filename, content, expected_result));
+    content::RunMessageLoop();
+  }
+
+ private:
+  // Create the test files, filesystem objects, etc.
+  void SetupOnFileThread(const std::string& filename,
+                         const std::string& content,
+                         bool expected_result) {
+    ASSERT_TRUE(base_.CreateUniqueTempDir());
+    base::FilePath base_dir = base_.path();
+    base::FilePath src_path = base_dir.Append(FILE_PATH_LITERAL("src_fs"));

[Lei Zhang, 2013/05/29 09:40:58]

Just AppendASCII() instead? Ditto below.

[vandebo (ex-Chrome), 2013/05/29 18:56:05]

Done.

+    file_util::CreateDirectory(src_path);

[Lei Zhang, 2013/05/29 09:40:58]

ASSERT_TRUE? Ditto below.

[vandebo (ex-Chrome), 2013/05/29 18:56:05]

Done.

+
+    ScopedVector<fileapi::FileSystemMountPointProvider> additional_providers;
+    additional_providers.push_back(new fileapi::TestMountPointProvider(
+        base::MessageLoopProxy::current(), src_path));
+    additional_providers.push_back(
+        new MediaFileSystemMountPointProvider(base_dir));
+    file_system_context_ =
+        fileapi::CreateFileSystemContextWithAdditionalProvidersForTesting(
+            NULL, additional_providers.Pass(), base_dir);
+
+    move_src_ = file_system_context_->CreateCrackedFileSystemURL(
+        GURL(kOrigin), fileapi::kFileSystemTypeTest,
+        base::FilePath::FromUTF8Unsafe(filename.c_str()));

[Lei Zhang, 2013/05/29 09:40:58]

omit the .c_str()

[vandebo (ex-Chrome), 2013/05/29 18:56:05]

Done.

+
+    test_file_size_ = content.size();
+    base::FilePath test_file = src_path.AppendASCII(filename.c_str());

[Lei Zhang, 2013/05/29 09:40:58]

Ditto? I think you can omit it.

[vandebo (ex-Chrome), 2013/05/29 18:56:05]

Done.

+    ASSERT_EQ(test_file_size_,
+              file_util::WriteFile(test_file, content.data(), test_file_size_));
+
+    base::FilePath dest_path = base_dir.Append(FILE_PATH_LITERAL("dest_fs"));
+    file_util::CreateDirectory(dest_path);
+    std::string dest_fsid =
+        fileapi::IsolatedContext::GetInstance()->RegisterFileSystemForPath(
+            fileapi::kFileSystemTypeNativeMedia, dest_path, NULL);
+
+    size_t extension_index = filename.find_last_of(".");

[Lei Zhang, 2013/05/29 09:40:58]

Maybe |filename| should just be a FilePath so you don't have to do this.

[vandebo (ex-Chrome), 2013/05/29 18:56:05]

GURL takes std::string/16, not FilePath::StringType.  I could do an ifdef for
windows, but for a unit test I think this is ok.

+    ASSERT_NE(std::string::npos, extension_index);
+    std::string extension = filename.substr(extension_index);
+    std::string dest_root_fs_url = fileapi::GetIsolatedFileSystemRootURIString(
+        GURL(kOrigin), dest_fsid, "dest_fs/");
+    move_dest_ = file_system_context_->CrackURL(GURL(
+          dest_root_fs_url + "move_dest" + extension));
+
+    content::BrowserThread::PostTask(
+        content::BrowserThread::IO,
+        FROM_HERE,
+        base::Bind(&MediaFileValidatorTest::CheckFiles,
+                   base::Unretained(this), true,
+                   base::Bind(&MediaFileValidatorTest::OnTestFilesReady,
+                              base::Unretained(this), expected_result)));
+  }
+
+  // Check that exactly one of |move_src_| and |move_dest_| exists.
+  // |src_expected| indicates which one should exist.  When complete,
+  // |callback| is called with success/failure.
+  void CheckFiles(bool src_expected,
+                  const base::Callback<void(bool success)>& callback) {
+    CheckFile(move_src_, src_expected ? test_file_size_ : kNoFileSize,
+              base::Bind(&MediaFileValidatorTest::OnCheckFilesFirstResult,
+                         base::Unretained(this), !src_expected, callback));
+  }
+
+  // Helper that checks a file has the |expected_size|, which may be
+  // |kNoFileSize| if the file should not exist.  |callback| is called
+  // with success/failure.
+  void CheckFile(fileapi::FileSystemURL url,
+                 int64 expected_size,
+                 const base::Callback<void(bool success)>& callback) {
+    CreateFSOp(url)->GetMetadata(url,
+                                 base::Bind(&HandleCheckFileResult,
+                                            expected_size, callback));
+  }
+
+  // Helper that checks the result of |move_src_| lookup and then checks
+  // |move_dest_| if all is as expected.
+  void OnCheckFilesFirstResult(bool dest_expected,
+                               const base::Callback<void(bool)>& callback,
+                               bool src_result) {
+    EXPECT_TRUE(src_result);
+    if (!src_result) {
+      callback.Run(false);
+      return;
+    }
+    CheckFile(move_dest_, dest_expected ? test_file_size_ : kNoFileSize,
+              callback);
+  }
+
+  // Assert |test_files_ready| and then do the actual test of moving
+  // |move_src_| to |move_dest_|.
+  void OnTestFilesReady(bool expected_result, bool test_files_ready) {
+    ASSERT_TRUE(test_files_ready);
+    CreateFSOp(move_dest_)->Move(
+        move_src_, move_dest_,
+        base::Bind(&MediaFileValidatorTest::OnMoveResult,
+                   base::Unretained(this), expected_result));
+  }
+
+  // Check that the move succeeded/failed based on expectation and then
+  // check that the right file exists.
+  void OnMoveResult(bool expected_result, base::PlatformFileError result) {
+    if (expected_result)
+      EXPECT_EQ(base::PLATFORM_FILE_OK, result);
+    else
+      EXPECT_EQ(base::PLATFORM_FILE_ERROR_SECURITY, result);
+    CheckFiles(!expected_result,
+               base::Bind(&MediaFileValidatorTest::OnTestFilesCheckResult,
+                          base::Unretained(this)));
+  }
+
+  // Check that the correct test file exists and then post the result back
+  // to the UI thread.
+  void OnTestFilesCheckResult(bool result) {
+    EXPECT_TRUE(result);
+    content::BrowserThread::PostTask(
+        content::BrowserThread::UI,
+        FROM_HERE,
+        base::Bind(&MediaFileValidatorTest::TestCompleteOnUIThread,
+                   base::Unretained(this)));
+  }
+
+  void TestCompleteOnUIThread(void) {
+    MessageLoop::current()->Quit();

[Lei Zhang, 2013/05/29 09:40:58]

needs base::, the crutch in message_loop.h will go away soon.

[vandebo (ex-Chrome), 2013/05/29 18:56:05]

Fixed up in a cleaner way.

+  }
+
+  fileapi::FileSystemOperation* CreateFSOp(fileapi::FileSystemURL url) {

[Lei Zhang, 2013/05/29 09:40:58]

|url| can be const ref.

[vandebo (ex-Chrome), 2013/05/29 18:56:05]

Done.

+    return file_system_context_->CreateFileSystemOperation(url, NULL);
+  }
+
+  base::ScopedTempDir base_;

[Lei Zhang, 2013/05/29 09:40:58]

how about base_dir_?

[vandebo (ex-Chrome), 2013/05/29 18:56:05]

Done.

+
+  scoped_refptr<fileapi::FileSystemContext> file_system_context_;
+
+  int test_file_size_;
+
+  fileapi::FileSystemURL move_src_;
+  fileapi::FileSystemURL move_dest_;
+
+  DISALLOW_COPY_AND_ASSIGN(MediaFileValidatorTest);
+};
+
+IN_PROC_BROWSER_TEST_F(MediaFileValidatorTest, ValidImage) {
+  MoveTest("a.webp", std::string(kValidImage, arraysize(kValidImage)), true);
+}
+
+IN_PROC_BROWSER_TEST_F(MediaFileValidatorTest, InvalidImage) {
+  MoveTest("a.webp", std::string(kInvalidImage, arraysize(kInvalidImage)),
+           false);
+}
+
+IN_PROC_BROWSER_TEST_F(MediaFileValidatorTest, UnsupportedExtension) {
+  MoveTest("a.txt", std::string(kValidImage, arraysize(kValidImage)), false);
+}
+
+}  // namespace chrome