Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1562353004: Oilpan: hold onto MediaQueryEvaluator singletons with Persistents. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: hold onto MediaQueryEvaluator singletons with Persistents. Add missing Persistent<> wrappers around MediaQueryEvaluator singletons; a regression introduced by r367489. R=haraken BUG= Committed: https://crrev.com/ede5d4f8a7bdad36ef6ab9ca512bc9da6072cfaa Cr-Commit-Position: refs/heads/master@{#368310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 11 months ago (2016-01-08 08:04:07 UTC) #2
haraken
LGTM
4 years, 11 months ago (2016-01-08 08:09:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562353004/1
4 years, 11 months ago (2016-01-08 09:24:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 10:48:29 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 10:49:38 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ede5d4f8a7bdad36ef6ab9ca512bc9da6072cfaa
Cr-Commit-Position: refs/heads/master@{#368310}

Powered by Google App Engine
This is Rietveld 408576698