Remove out/apprtc using Cygwin for Windows bots.

Remove out/apprtc using Cygwin for Windows bots.

This requires Cygwin to be installed in c:\cygwin, which
is the case on all our Windows testers.

BUG=567538
R=phoglund@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/f9361f6c50155cae864d8b955fc52574160ee35f

[kjellander_chromium, 2016-01-07 14:28:14]

kjellander@chromium.org changed reviewers:
+ phoglund@chromium.org

[kjellander_chromium, 2016-01-07 14:28:15]

Maybe this will work....

[phoglund_chromium, 2016-01-07 14:31:47]

https://codereview.chromium.org/1562343003/diff/1/copy_apprtc.py
File copy_apprtc.py (right):

https://codereview.chromium.org/1562343003/diff/1/copy_apprtc.py#newcode29
copy_apprtc.py:29: def RemoveDirectoryWithCygwinRmIfWindows(*path):
This name is misleading since it implies it only deletes on Windows. Just call
it RemoveDirectory.

https://codereview.chromium.org/1562343003/diff/1/copy_apprtc.py#newcode35
copy_apprtc.py:35: full_path = full_path[0].lower() + full_path[1:]  # c:\b\...
This is alright, but you can use splitdrive to make it a bit cleaner.

[kjellander_chromium, 2016-01-07 14:40:06]

PTAL

https://codereview.chromium.org/1562343003/diff/1/copy_apprtc.py
File copy_apprtc.py (right):

https://codereview.chromium.org/1562343003/diff/1/copy_apprtc.py#newcode29
copy_apprtc.py:29: def RemoveDirectoryWithCygwinRmIfWindows(*path):
On 2016/01/07 14:31:47, phoglund_chrome wrote:
> This name is misleading since it implies it only deletes on Windows. Just call
> it RemoveDirectory.

Done.

https://codereview.chromium.org/1562343003/diff/1/copy_apprtc.py#newcode35
copy_apprtc.py:35: full_path = full_path[0].lower() + full_path[1:]  # c:\b\...
On 2016/01/07 14:31:47, phoglund_chrome wrote:
> This is alright, but you can use splitdrive to make it a bit cleaner.

Of course! Much better now.

https://codereview.chromium.org/1562343003/diff/20001/copy_apprtc.py
File copy_apprtc.py (right):

https://codereview.chromium.org/1562343003/diff/20001/copy_apprtc.py#newcode34
copy_apprtc.py:34: cygwin_full_path = '/cygdrive/%s%s' % (drive.lower(),
No dir separator between the drive and path since the documentation says:

os.path.splitdrive(path)
Split the pathname path into a pair (drive, tail) where drive is either a drive
specification or the empty string. On systems which do not use drive
specifications, drive will always be the empty string. In all cases, drive +
tail will be the same as path.

[phoglund_chromium, 2016-01-07 14:43:26]

https://codereview.chromium.org/1562343003/diff/20001/copy_apprtc.py
File copy_apprtc.py (right):

https://codereview.chromium.org/1562343003/diff/20001/copy_apprtc.py#newcode34
copy_apprtc.py:34: cygwin_full_path = '/cygdrive/%s%s' % (drive.lower(),
On 2016/01/07 14:40:06, kjellander (chromium) wrote:
> No dir separator between the drive and path since the documentation says:
> 
> os.path.splitdrive(path)
> Split the pathname path into a pair (drive, tail) where drive is either a
drive
> specification or the empty string. On systems which do not use drive
> specifications, drive will always be the empty string. In all cases, drive +
> tail will be the same as path.

I tried on Windows, and os.path.splitdrive('C:\klas\ola') yields (r'C:',
r'\\klas\\ola'). You still need to get rid of the : from the drive. Just do
drive.lower()[0] on line 33. Also you don't need the drive.lower on line 34.

[kjellander_chromium, 2016-01-07 14:48:01]

ok, now then?

https://codereview.chromium.org/1562343003/diff/20001/copy_apprtc.py
File copy_apprtc.py (right):

https://codereview.chromium.org/1562343003/diff/20001/copy_apprtc.py#newcode34
copy_apprtc.py:34: cygwin_full_path = '/cygdrive/%s%s' % (drive.lower(),
On 2016/01/07 14:43:26, phoglund_chrome wrote:
> On 2016/01/07 14:40:06, kjellander (chromium) wrote:
> > No dir separator between the drive and path since the documentation says:
> > 
> > os.path.splitdrive(path)
> > Split the pathname path into a pair (drive, tail) where drive is either a
> drive
> > specification or the empty string. On systems which do not use drive
> > specifications, drive will always be the empty string. In all cases, drive +
> > tail will be the same as path.
> 
> I tried on Windows, and os.path.splitdrive('C:\klas\ola') yields (r'C:',
> r'\\klas\\ola'). You still need to get rid of the : from the drive. Just do
> drive.lower()[0] on line 33. Also you don't need the drive.lower on line 34.

Done.

[phoglund_chromium, 2016-01-07 14:50:46]

lgtm

[kjellander_chromium, 2016-01-07 14:51:48]

Description was changed from

==========
Remove out/apprtc using Cygwin for Windows bots.

This requires Cygwin to be installed in c:\cygwin, which
is the case on all our Windows testers.

BUG=567538
==========

to

==========
Remove out/apprtc using Cygwin for Windows bots.

This requires Cygwin to be installed in c:\cygwin, which
is the case on all our Windows testers.

BUG=567538
R=phoglund@chromium.org

Committed:
https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/f9361f6c...
==========

[kjellander_chromium, 2016-01-07 14:51:49]

Committed patchset #3 (id:40001) manually as
f9361f6c50155cae864d8b955fc52574160ee35f (presubmit successful).