OLD | NEW |
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
9 """ | 9 """ |
10 | 10 |
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
242 'OS_BSD', | 242 'OS_BSD', |
243 'OS_CAT', # For testing. | 243 'OS_CAT', # For testing. |
244 'OS_CHROMEOS', | 244 'OS_CHROMEOS', |
245 'OS_FREEBSD', | 245 'OS_FREEBSD', |
246 'OS_IOS', | 246 'OS_IOS', |
247 'OS_LINUX', | 247 'OS_LINUX', |
248 'OS_MACOSX', | 248 'OS_MACOSX', |
249 'OS_NACL', | 249 'OS_NACL', |
250 'OS_OPENBSD', | 250 'OS_OPENBSD', |
251 'OS_POSIX', | 251 'OS_POSIX', |
| 252 'OS_QNX', |
252 'OS_SOLARIS', | 253 'OS_SOLARIS', |
253 'OS_WIN', | 254 'OS_WIN', |
254 ) | 255 ) |
255 | 256 |
256 | 257 |
257 def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api): | 258 def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api): |
258 """Attempts to prevent use of functions intended only for testing in | 259 """Attempts to prevent use of functions intended only for testing in |
259 non-testing code. For now this is just a best-effort implementation | 260 non-testing code. For now this is just a best-effort implementation |
260 that ignores header files and may have some false positives. A | 261 that ignores header files and may have some false positives. A |
261 better implementation would probably need a proper C++ parser. | 262 better implementation would probably need a proper C++ parser. |
(...skipping 1196 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
1458 trybots.extend(GetDefaultTryConfigs(['cros_x86'])) | 1459 trybots.extend(GetDefaultTryConfigs(['cros_x86'])) |
1459 | 1460 |
1460 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it | 1461 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it |
1461 # unless they're .gyp(i) files as changes to those files can break the gyp | 1462 # unless they're .gyp(i) files as changes to those files can break the gyp |
1462 # step on that bot. | 1463 # step on that bot. |
1463 if (not all(re.search('^chrome', f) for f in files) or | 1464 if (not all(re.search('^chrome', f) for f in files) or |
1464 any(re.search('\.gypi?$', f) for f in files)): | 1465 any(re.search('\.gypi?$', f) for f in files)): |
1465 trybots.extend(GetDefaultTryConfigs(['android_aosp'])) | 1466 trybots.extend(GetDefaultTryConfigs(['android_aosp'])) |
1466 | 1467 |
1467 return trybots | 1468 return trybots |
OLD | NEW |