Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1562293002: Remove FrameView::m_inPerformLayout (Closed)

Created:
4 years, 11 months ago by davve
Modified:
4 years, 11 months ago
Reviewers:
esprehn
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FrameView::m_inPerformLayout Use the document lifecycle instead of a flag in FrameView to find out if we're inside performLayout(). Committed: https://crrev.com/24b28bf641808187a48f1f2f47bfcf19bea81ade Cr-Commit-Position: refs/heads/master@{#368289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562293002/1
4 years, 11 months ago (2016-01-07 12:46:47 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-07 14:05:21 UTC) #4
davve
m_inPerformLayout looks so suspiciously loose, I wonder if I've missed something... PTAL.
4 years, 11 months ago (2016-01-07 15:56:02 UTC) #6
esprehn
Lgtm, seems legit.
4 years, 11 months ago (2016-01-07 17:39:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562293002/1
4 years, 11 months ago (2016-01-08 07:01:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 07:08:06 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 07:09:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24b28bf641808187a48f1f2f47bfcf19bea81ade
Cr-Commit-Position: refs/heads/master@{#368289}

Powered by Google App Engine
This is Rietveld 408576698