Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1562263002: dart2js cps: Disable units tests that check the exact compiler output. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Disable units tests that check the exact compiler output. These were sort of useful, but are way too expensive to maintain and have broken the build bots way more often than they have uncovered bugs. If we want to monitor the concrete compiler output we should build real tools for that. They are not unit tests. BUG= Committed: https://github.com/dart-lang/sdk/commit/bb129a2d0793093e8612f91cd2cba79bf2e2379b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M tests/compiler/dart2js/dart2js.status View 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
TBR
4 years, 11 months ago (2016-01-07 00:47:26 UTC) #2
asgerf
Committed patchset #1 (id:1) manually as bb129a2d0793093e8612f91cd2cba79bf2e2379b (presubmit successful).
4 years, 11 months ago (2016-01-07 00:47:52 UTC) #4
Kevin Millikin (Google)
4 years, 11 months ago (2016-01-07 00:48:05 UTC) #5
Message was sent while issue was closed.
LGTM!

Powered by Google App Engine
This is Rietveld 408576698