Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1562253002: Add a CompareAndSwapUint32 variant to AtomicOperations so that it is possible to a CAS of a 32 bit … (Closed)

Created:
4 years, 11 months ago by siva
Modified:
4 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a CompareAndSwapUint32 variant to AtomicOperations so that it is possible to a CAS of a 32 bit value. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a7ebeb00fbb09b774836239b31d2c7defcc12c9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -0 lines) Patch
M runtime/vm/atomic.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/atomic_android.h View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/atomic_linux.h View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/atomic_macos.h View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/atomic_simulator.h View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/atomic_test.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/vm/atomic_win.h View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M runtime/vm/simulator_mips.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 11 months ago (2016-01-06 23:36:38 UTC) #2
rmacnak
lgtm
4 years, 11 months ago (2016-01-07 00:46:02 UTC) #3
siva
4 years, 11 months ago (2016-01-07 01:08:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7ebeb00fbb09b774836239b31d2c7defcc12c9c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698