Introduce LiteralSet

Source/wtf/TableSet.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef Task_h
-#define Task_h
+#ifndef WTF_TableSet_h
+#define WTF_TableSet_h
 
-#include "wtf/Functional.h"
-#include <public/WebThread.h>
+#include "wtf/NonCopyingSort.h"
 
-namespace WebCore {
+#include <algorithm>
 
-class Task : public WebKit::WebThread::Task {
+namespace WTF {
+
+template<typename T>
+class TableSet {

[eseidel, 2013/05/22 00:40:14]

This needs to be more scary.  And I would add a header-level comment explaining
this pattern.

 public:
-    explicit Task(const Closure& closure)
-        : m_closure(closure)
+    typedef bool (*Predicate)(const T&, const T&);
+
+    explicit TableSet(Predicate compareLess)
+        : m_compareLess(compareLess)
+        , m_values(0)
+        , m_size(0)
     {
     }
 
-    virtual void run() OVERRIDE
+    void init(T values[], size_t size)
     {
-        m_closure();
+        ASSERT(isEmpty());
+        m_values = values;
+        m_size = size;
+        nonCopyingSort(m_values, m_values + m_size, m_compareLess);
     }
 
+    bool contains(const T& value)
+    {
+        ASSERT(!isEmpty());

[eseidel, 2013/05/22 00:40:14]

Do you also want to ASSERT That value is never null?

[abarth-chromium, 2013/05/22 00:58:25]

It's a const reference.  There's no way for a const reference to be null.

+        return std::binary_search(m_values, m_values + m_size, value, m_compareLess);
+    }
+
+    bool isEmpty() { return !m_size; }

[eseidel, 2013/05/22 00:40:14]

This is really isInitialized, no?

[abarth-chromium, 2013/05/22 00:58:25]

Yep.

+
 private:
-    Closure m_closure;
+    Predicate m_compareLess;
+    T* m_values;
+    size_t m_size;
 };
 
-} // namespace WebCore
+} // namespace WTF
 
-#endif // Task_h
+using WTF::TableSet;
+
+#endif