Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 156213002: Fix SkXPSDevice (Closed)

Created:
6 years, 10 months ago by Dominik Grewe
Modified:
6 years, 10 months ago
Reviewers:
Stephen White, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix SkXPSDevice Make SkImageFilter parameter for SkXPSDevice::allowImageFilter const to match the SkBitmapDevice base class. BUG=skia:2097 R=senorblanco@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=13333

Patch Set 1 #

Patch Set 2 : Fix tests/ImageFilterTest.cpp #

Patch Set 3 : Re-upload #

Patch Set 4 : Remove fix to MatrixTestImageFilter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/device/xps/SkXPSDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Dominik Grewe
Failed on the bots: http://108.170.217.252:10117/builders/Test-Win7-ShuttleA-HD2000-x86_64-Debug/builds/1642/steps/BuildMost/logs/stdio I compiled everything on my Mac using 'ninja -C out/Debug' ...
6 years, 10 months ago (2014-02-05 22:52:29 UTC) #1
Stephen White
LGTM
6 years, 10 months ago (2014-02-05 23:15:50 UTC) #2
Dominik Grewe
The CQ bit was checked by dominikg@chromium.org
6 years, 10 months ago (2014-02-05 23:16:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dominikg@chromium.org/156213002/120001
6 years, 10 months ago (2014-02-05 23:16:40 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 23:16:42 UTC) #5
commit-bot: I haz the power
Presubmit check for 156213002-120001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 10 months ago (2014-02-05 23:16:43 UTC) #6
Stephen White
6 years, 10 months ago (2014-02-05 23:23:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r13333.

Powered by Google App Engine
This is Rietveld 408576698