Chromium Code Reviews

Issue 1562083003: [compiler] Treat all embedded context references weakly. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Hannes Payer (out of office)
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Treat all embedded context references weakly. Previously only references to function contexts embedded in optimized were treated weakly, but TurboFan (and to some extend Crankshaft) can embed any kind of context into optimized code. R=hpayer@chromium.org Committed: https://crrev.com/f755176110c00a868a59bd0e510b10d72a944c31 Cr-Commit-Position: refs/heads/master@{#33155}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+2 lines, -5 lines)
M src/objects-inl.h View 1 chunk +2 lines, -5 lines 0 comments

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-07 13:45:08 UTC) #1
Hannes Payer (out of office)
lgtm
4 years, 11 months ago (2016-01-07 13:53:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562083003/1
4 years, 11 months ago (2016-01-07 13:53:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 14:08:55 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 14:09:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f755176110c00a868a59bd0e510b10d72a944c31
Cr-Commit-Position: refs/heads/master@{#33155}

Powered by Google App Engine