Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1562073003: net: exclude directory_listing_unittest.cc from the build when the file support is disabled (Closed)

Created:
4 years, 11 months ago by tfarina
Modified:
4 years, 11 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: exclude directory_listing_unittest.cc from the build when the file support is disabled This should fix the following error: obj/net/base/net_unittests.directory_listing_unittest.o:directory_listing_unittest.cc:function net::(anonymous namespace)::DirectoryListingTest_GetDirectoryListingEntry_Test::TestBody(): error: undefined reference to 'net::GetDirectoryListingEntry(std::__1::basic_string<unsigned short, base::string16_char_traits, std::__1::allocator<unsigned short> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, long long, base::Time)' https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Data%20Reduction%20Proxy%20Builder/builds/1005/steps/compile/logs/stdio BUG=488531 R=eroman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d673bb12d190f6ca380714b8d62ee6c01f5fc2a4

Patch Set 1 #

Patch Set 2 : for gyp too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M net/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
Fingers crossed!
4 years, 11 months ago (2016-01-06 23:10:23 UTC) #1
eroman
lgtm
4 years, 11 months ago (2016-01-06 23:10:29 UTC) #2
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d673bb12d190f6ca380714b8d62ee6c01f5fc2a4 Cr-Commit-Position: refs/heads/master@{#367951}
4 years, 11 months ago (2016-01-06 23:26:08 UTC) #4
tfarina
Committed patchset #2 (id:20001) manually as d673bb12d190f6ca380714b8d62ee6c01f5fc2a4 (presubmit successful).
4 years, 11 months ago (2016-01-06 23:26:47 UTC) #6
tfarina
4 years, 11 months ago (2016-01-06 23:37:55 UTC) #7
Message was sent while issue was closed.
Eric, Daniel, I'm heading bed now. If this does not solve the link issue, I will
hit the revert box on this and then on the first patch.

Powered by Google App Engine
This is Rietveld 408576698