Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1562043002: Reland of move Pass() on Android. (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang, msramek
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of move Pass() on Android. (patchset #1 id:1 of https://codereview.chromium.org/1564763002/ ) Reason for revert: Relanding because the build config in question is not covered by any trybots or the default waterfall. Per the discussion: 1) Keeping this reverted makes things harder to reland, due to the possibility of mid-air collisions. 2) The remaining failures will be fixed shortly afterwards in a followup patch. Original issue's description: > Revert of Remove Pass() on Android. (patchset #1 id:1 of https://codereview.chromium.org/1559603002/ ) > > Reason for revert: > This breaks compilation, as there are still some callsites of Pass() left. > > See Android Cronet Data Reduction Proxy Builder build #961 and onwards: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Data%20Reduction%20Proxy%20Builder/builds/961/steps/compile/logs/stdio > > Original issue's description: > > Remove Pass() on Android. > > > > Pass() is a legacy of the original C++03 move emulation implementation. > > New code should use std::move from <utility>. > > > > ❆(੭ु ◜◡‾)੭ु⁾☃❆ > > > > BUG=557422 > > R=thestig@chromium.org > > > > Committed: https://crrev.com/92469c8c4b7da052273dee1a31308663d1dd1e3d > > Cr-Commit-Position: refs/heads/master@{#367251} > > TBR=thestig@chromium.org,dcheng@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=557422 > > Committed: https://crrev.com/f737edcf768bad1883164ac1c2270df670c7f6a9 > Cr-Commit-Position: refs/heads/master@{#367811} TBR=thestig@chromium.org,msramek@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557422 Committed: https://crrev.com/42e9dcf1c68f681559771efd08b30e60dec3658d Cr-Commit-Position: refs/heads/master@{#367820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/memory/scoped_ptr_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/move.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
Created Reland of move Pass() on Android.
4 years, 11 months ago (2016-01-06 14:15:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562043002/1
4 years, 11 months ago (2016-01-06 14:15:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 14:16:17 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/42e9dcf1c68f681559771efd08b30e60dec3658d Cr-Commit-Position: refs/heads/master@{#367820}
4 years, 11 months ago (2016-01-06 14:17:06 UTC) #5
msramek
4 years, 11 months ago (2016-01-06 14:17:51 UTC) #6
Message was sent while issue was closed.
(Sheriff:) LGTM as per offline discussion.

Powered by Google App Engine
This is Rietveld 408576698