DescriptionReland of move Pass() on Android. (patchset #1 id:1 of https://codereview.chromium.org/1564763002/ )
Reason for revert:
Relanding because the build config in question is not covered by any trybots or the default waterfall.
Per the discussion:
1) Keeping this reverted makes things harder to reland, due to the possibility of mid-air collisions.
2) The remaining failures will be fixed shortly afterwards in a followup patch.
Original issue's description:
> Revert of Remove Pass() on Android. (patchset #1 id:1 of https://codereview.chromium.org/1559603002/ )
>
> Reason for revert:
> This breaks compilation, as there are still some callsites of Pass() left.
>
> See Android Cronet Data Reduction Proxy Builder build #961 and onwards: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Data%20Reduction%20Proxy%20Builder/builds/961/steps/compile/logs/stdio
>
> Original issue's description:
> > Remove Pass() on Android.
> >
> > Pass() is a legacy of the original C++03 move emulation implementation.
> > New code should use std::move from <utility>.
> >
> > ❆(੭ु ◜◡‾)੭ु⁾☃❆
> >
> > BUG=557422
> > R=thestig@chromium.org
> >
> > Committed: https://crrev.com/92469c8c4b7da052273dee1a31308663d1dd1e3d
> > Cr-Commit-Position: refs/heads/master@{#367251}
>
> TBR=thestig@chromium.org,dcheng@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=557422
>
> Committed: https://crrev.com/f737edcf768bad1883164ac1c2270df670c7f6a9
> Cr-Commit-Position: refs/heads/master@{#367811}
TBR=thestig@chromium.org,msramek@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557422
Committed: https://crrev.com/42e9dcf1c68f681559771efd08b30e60dec3658d
Cr-Commit-Position: refs/heads/master@{#367820}
Patch Set 1 #
Messages
Total messages: 6 (1 generated)
|