Add test of unittests.

Add test of unittests.

BUG=
R=sigurdm@google.com

Committed: https://github.com/dart-lang/sdk/commit/306537be7945ec9cf306f3c4b158ea5d540bf47f

[Johnni Winther, 2016-01-06 10:16:13]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[sigurdm, 2016-01-06 11:25:10]

LGTM

Reminder: Add test that the right error message is printed when a file with
part-of is used as entry-point.

https://codereview.chromium.org/1562023002/diff/20001/pkg/compiler/lib/src/li...
File pkg/compiler/lib/src/library_loader.dart (right):

https://codereview.chromium.org/1562023002/diff/20001/pkg/compiler/lib/src/li...
pkg/compiler/lib/src/library_loader.dart:152: /// compilation unit for
[resolvedUri] contains a `part of` tag.
Add that this is for the analysis path only.

https://codereview.chromium.org/1562023002/diff/20001/pkg/compiler/lib/src/li...
pkg/compiler/lib/src/library_loader.dart:155: {bool skipLibraryWithPartOfTag:
false});
Perhaps rename to `skipFileWithPartOfTag`

https://codereview.chromium.org/1562023002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/analyze_test_test.dart (right):

https://codereview.chromium.org/1562023002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/analyze_test_test.dart:1: // Copyright (c) 2015, the Dart
project authors.  Please see the AUTHORS file
`2015` -> `2016` - happy new year! :)

https://codereview.chromium.org/1562023002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/analyze_test_test.dart:69: CompilerImpl compiler =
compilerFor(
Unused?

[Johnni Winther, 2016-01-06 12:05:50]

On 2016/01/06 11:25:10, sigurdm wrote:
> LGTM
> 
> Reminder: Add test that the right error message is printed when a file with
> part-of is used as entry-point.

It wasn't. Starting a CL.

[Johnni Winther, 2016-01-06 12:19:52]

Description was changed from

==========
Add test of unittests.

BUG=
==========

to

==========
Add test of unittests.

BUG=
R=sigurdm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/306537be7945ec9cf306f3c4b158ea5d540bf47f
==========

[Johnni Winther, 2016-01-06 12:19:56]

Committed patchset #3 (id:40001) manually as
306537be7945ec9cf306f3c4b158ea5d540bf47f (presubmit successful).

[Johnni Winther, 2016-01-06 12:32:54]

https://codereview.chromium.org/1562023002/diff/20001/pkg/compiler/lib/src/li...
File pkg/compiler/lib/src/library_loader.dart (right):

https://codereview.chromium.org/1562023002/diff/20001/pkg/compiler/lib/src/li...
pkg/compiler/lib/src/library_loader.dart:152: /// compilation unit for
[resolvedUri] contains a `part of` tag.
On 2016/01/06 11:25:09, sigurdm wrote:
> Add that this is for the analysis path only.

Done.

https://codereview.chromium.org/1562023002/diff/20001/pkg/compiler/lib/src/li...
pkg/compiler/lib/src/library_loader.dart:155: {bool skipLibraryWithPartOfTag:
false});
On 2016/01/06 11:25:09, sigurdm wrote:
> Perhaps rename to `skipFileWithPartOfTag`

Done.

https://codereview.chromium.org/1562023002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/analyze_test_test.dart (right):

https://codereview.chromium.org/1562023002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/analyze_test_test.dart:1: // Copyright (c) 2015, the Dart
project authors.  Please see the AUTHORS file
On 2016/01/06 11:25:10, sigurdm wrote:
> `2015` -> `2016` - happy new year! :)

Done.

https://codereview.chromium.org/1562023002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/analyze_test_test.dart:69: CompilerImpl compiler =
compilerFor(
On 2016/01/06 11:25:09, sigurdm wrote:
> Unused?

Removed.

[sigurdm, 2016-01-06 12:34:44]

https://codereview.chromium.org/1562023002/diff/40001/tests/compiler/dart2js/...
File tests/compiler/dart2js/analyze_test_test.dart (right):

https://codereview.chromium.org/1562023002/diff/40001/tests/compiler/dart2js/...
tests/compiler/dart2js/analyze_test_test.dart:10: import
'package:compiler/src/apiimpl.dart' show
Nit: unused import

[Siggi Cherem (dart-lang), 2016-01-08 21:03:18]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-01-08 21:03:19]

https://codereview.chromium.org/1562023002/diff/40001/tests/compiler/dart2js/...
File tests/compiler/dart2js/analyze_test_test.dart (right):

https://codereview.chromium.org/1562023002/diff/40001/tests/compiler/dart2js/...
tests/compiler/dart2js/analyze_test_test.dart:34: "Library
'package:async/async.dart' doesn't export a "
I'm seeing a local failure related to this line. The bots seem to be OK, but
locally I get that this warning is never emitted. Is there something I am
missing in my local checkout?

I tried gclient sync and gclient runhooks, thinking maybe this is related to the
latest version of package:test, but no luck so far. Any ideas?

Thanks!

[Johnni Winther, 2016-01-11 09:52:24]

On 2016/01/08 21:03:19, Siggi Cherem (dart-lang) wrote:
>
https://codereview.chromium.org/1562023002/diff/40001/tests/compiler/dart2js/...
> File tests/compiler/dart2js/analyze_test_test.dart (right):
> 
>
https://codereview.chromium.org/1562023002/diff/40001/tests/compiler/dart2js/...
> tests/compiler/dart2js/analyze_test_test.dart:34: "Library
> 'package:async/async.dart' doesn't export a "
> I'm seeing a local failure related to this line. The bots seem to be OK, but
> locally I get that this warning is never emitted. Is there something I am
> missing in my local checkout?
> 
> I tried gclient sync and gclient runhooks, thinking maybe this is related to
the
> latest version of package:test, but no luck so far. Any ideas?
> 
> Thanks!

I'll update the test to allow some warnings to unemitted. This kind is clearly a
candidate.