Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1561993003: DM: add a pixel check to serialize (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: add a pixel check to serialize If we're running through serialize and then drawing into some raster target (e.g. serialize-8888 like we run on the bots), make sure the serialized version is identical to what we'd get if we just drew into the rest of the pipeline (i.e. 8888). Start by blacklisting all current failures. This at least prevents further regression. BUG=skia:4095 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1561993003 Committed: https://skia.googlesource.com/skia/+/6eb4e36a93ea695e7adb771ea9ac3326680a8e98 CQ_EXTRA_TRYBOTS=client.skia:Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot Committed: https://skia.googlesource.com/skia/+/5820fe846fc699b4623c09ed4e24f44122e00c40

Patch Set 1 #

Patch Set 2 : update blacklist #

Patch Set 3 : note bug #

Patch Set 4 : typo #

Patch Set 5 : more on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1120 lines, -70 lines) Patch
M dm/DMSrcSink.cpp View 2 chunks +18 lines, -0 lines 0 comments Download
M tools/dm_flags.json View 1 2 3 4 12 chunks +1077 lines, -69 lines 0 comments Download
M tools/dm_flags.py View 1 2 3 4 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 24 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561993003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561993003/40001
4 years, 11 months ago (2016-01-06 20:44:14 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/5058)
4 years, 11 months ago (2016-01-06 20:52:26 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561993003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561993003/60001
4 years, 11 months ago (2016-01-06 20:57:22 UTC) #8
mtklein_C
4 years, 11 months ago (2016-01-06 21:12:52 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-06 21:22:15 UTC) #12
reed1
sweet lgtm
4 years, 11 months ago (2016-01-06 22:17:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561993003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561993003/60001
4 years, 11 months ago (2016-01-06 22:19:53 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/6eb4e36a93ea695e7adb771ea9ac3326680a8e98
4 years, 11 months ago (2016-01-06 22:20:33 UTC) #17
caryclark
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1563923003/ by caryclark@google.com. ...
4 years, 11 months ago (2016-01-07 13:11:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561993003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561993003/80001
4 years, 11 months ago (2016-01-07 15:08:57 UTC) #22
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 15:38:31 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/5820fe846fc699b4623c09ed4e24f44122e00c40

Powered by Google App Engine
This is Rietveld 408576698