Fix null receiver guard an uncached site.

Fix null receiver guard on uncached path.

We has two copies of the inlining preparation code, so I put it in a local function.

This fixes some of the errant .toString guards but not all.

BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/ac0d8dbd812122ff13570f1dc19c981a3d4d64ab

[sra1, 2016-01-07 01:26:51]

Patchset #1 (id:1) has been deleted

[sra1, 2016-01-07 01:26:56]

Patchset #1 (id:20001) has been deleted

[sra1, 2016-01-07 01:29:24]

Description was changed from

==========
Fix null receiver guard an uncached site.

BUG=
==========

to

==========
Fix null receiver guard on uncached path.

We has two copies of the inlining preparation code, so I put it in a local
function.

This fixes some of the errant .toString guards but not all.

BUG=
==========

[sra1, 2016-01-07 01:29:24]

sra@google.com changed reviewers:
+ kmillikin@google.com

[Kevin Millikin (Google), 2016-01-07 18:15:08]

LGTM

https://codereview.chromium.org/1561953005/diff/40001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/inline.dart (right):

https://codereview.chromium.org/1561953005/diff/40001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/inline.dart:386: Reference<Primitive> dartReceiver =
invoke.dartReceiverReference;
This is already in scope, isn't it?

[sra1, 2016-01-07 18:22:50]

Description was changed from

==========
Fix null receiver guard on uncached path.

We has two copies of the inlining preparation code, so I put it in a local
function.

This fixes some of the errant .toString guards but not all.

BUG=
==========

to

==========
Fix null receiver guard on uncached path.

We has two copies of the inlining preparation code, so I put it in a local
function.

This fixes some of the errant .toString guards but not all.

BUG=
R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ac0d8dbd812122ff13570f1dc19c981a3d4d64ab
==========

[sra1, 2016-01-07 18:22:51]

Committed patchset #2 (id:60001) manually as
ac0d8dbd812122ff13570f1dc19c981a3d4d64ab (presubmit successful).

[sra1, 2016-01-07 18:23:14]

https://codereview.chromium.org/1561953005/diff/40001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/inline.dart (right):

https://codereview.chromium.org/1561953005/diff/40001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/inline.dart:386: Reference<Primitive> dartReceiver =
invoke.dartReceiverReference;
On 2016/01/07 18:15:08, Kevin Millikin (Google) wrote:
> This is already in scope, isn't it?

Yes, thanks.