Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1561943002: X87: Remove strong mode support from rest argument creation. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Remove strong mode support from rest argument creation. port a94d6d6ede70fc42eed382ec8742af9734a37406 (r33108) original commit message: The mode requires an extra register, and since we aren't supporting it now, we can dispense with it. BUG= Committed: https://crrev.com/a3fd2b8174e397d0e46bdcd94d3440c74e55d7d6 Cr-Commit-Position: refs/heads/master@{#33147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 11 months ago (2016-01-06 03:03:31 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2016-01-07 06:37:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561943002/1
4 years, 11 months ago (2016-01-07 06:37:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 07:02:36 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 07:02:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3fd2b8174e397d0e46bdcd94d3440c74e55d7d6
Cr-Commit-Position: refs/heads/master@{#33147}

Powered by Google App Engine
This is Rietveld 408576698