Vectorize tab recording and capturing icons.

Vectorize tab recording and capturing icons.

Handling themes (e.g. dark custom themes) is a TODO, but the asset icons don't handle them either so this is not a regression.

BUG=520623, 575031
TBR=oshima@chromium.org

Committed: https://crrev.com/e5ee6ef233b697aba7475122b8ba48db2b453a2e
Cr-Commit-Position: refs/heads/master@{#368470}

[Evan Stade, 2016-01-07 01:16:18]

Description was changed from

==========
Vectorize tab recording and capturing icons.

BUG=520623
==========

to

==========
Vectorize tab recording and capturing icons.

Handling themes (e.g. dark custom themes) is a TODO, but the asset icons don't
handle them either so this is not a regression.

BUG=520623
==========

[Evan Stade, 2016-01-07 01:16:19]

estade@chromium.org changed reviewers:
+ miu@chromium.org

[Evan Stade, 2016-01-07 02:41:28]

Description was changed from

==========
Vectorize tab recording and capturing icons.

Handling themes (e.g. dark custom themes) is a TODO, but the asset icons don't
handle them either so this is not a regression.

BUG=520623
==========

to

==========
Vectorize tab recording and capturing icons.

Handling themes (e.g. dark custom themes) is a TODO, but the asset icons don't
handle them either so this is not a regression.

BUG=520623, 575031
==========

[miu, 2016-01-07 20:08:09]

lgtm % nits:

https://codereview.chromium.org/1561923005/diff/1/chrome/browser/ui/tabs/tab_...
File chrome/browser/ui/tabs/tab_utils.cc (right):

https://codereview.chromium.org/1561923005/diff/1/chrome/browser/ui/tabs/tab_...
chrome/browser/ui/tabs/tab_utils.cc:27: #if !defined(OS_MACOSX)
nit: For readability, please negate the expression, swapping the then-clause
with the else-clause.

https://codereview.chromium.org/1561923005/diff/1/chrome/browser/ui/tabs/tab_...
chrome/browser/ui/tabs/tab_utils.cc:172: #if !defined(OS_MACOSX)
ditto: negate expression for readability

[Evan Stade, 2016-01-08 21:47:02]

estade@chromium.org changed reviewers:
+ oshima@chromium.org

[Evan Stade, 2016-01-08 21:47:02]

tbr +oshima for c/a/t

https://codereview.chromium.org/1561923005/diff/1/chrome/browser/ui/tabs/tab_...
File chrome/browser/ui/tabs/tab_utils.cc (right):

https://codereview.chromium.org/1561923005/diff/1/chrome/browser/ui/tabs/tab_...
chrome/browser/ui/tabs/tab_utils.cc:27: #if !defined(OS_MACOSX)
On 2016/01/07 20:08:09, miu wrote:
> nit: For readability, please negate the expression, swapping the then-clause
> with the else-clause.

Done.

https://codereview.chromium.org/1561923005/diff/1/chrome/browser/ui/tabs/tab_...
chrome/browser/ui/tabs/tab_utils.cc:172: #if !defined(OS_MACOSX)
On 2016/01/07 20:08:09, miu wrote:
> ditto: negate expression for readability

Done.

[Evan Stade, 2016-01-08 21:47:19]

Description was changed from

==========
Vectorize tab recording and capturing icons.

Handling themes (e.g. dark custom themes) is a TODO, but the asset icons don't
handle them either so this is not a regression.

BUG=520623, 575031
==========

to

==========
Vectorize tab recording and capturing icons.

Handling themes (e.g. dark custom themes) is a TODO, but the asset icons don't
handle them either so this is not a regression.

BUG=520623, 575031
TBR=oshima@chromium.org
==========

[Evan Stade, 2016-01-08 21:47:23]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-01-08 21:47:23]

The patchset sent to the CQ was uploaded after l-g-t-m from miu@chromium.org
Link to the patchset: https://codereview.chromium.org/1561923005/#ps20001
(title: "miu nits")

[commit-bot: I haz the power, 2016-01-08 21:48:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1561923005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1561923005/20001

[oshima, 2016-01-08 22:05:43]

lgtm

[commit-bot: I haz the power, 2016-01-09 00:09:00]

Description was changed from

==========
Vectorize tab recording and capturing icons.

Handling themes (e.g. dark custom themes) is a TODO, but the asset icons don't
handle them either so this is not a regression.

BUG=520623, 575031
TBR=oshima@chromium.org
==========

to

==========
Vectorize tab recording and capturing icons.

Handling themes (e.g. dark custom themes) is a TODO, but the asset icons don't
handle them either so this is not a regression.

BUG=520623, 575031
TBR=oshima@chromium.org
==========

[commit-bot: I haz the power, 2016-01-09 00:09:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-09 00:10:16]

Description was changed from

==========
Vectorize tab recording and capturing icons.

Handling themes (e.g. dark custom themes) is a TODO, but the asset icons don't
handle them either so this is not a regression.

BUG=520623, 575031
TBR=oshima@chromium.org
==========

to

==========
Vectorize tab recording and capturing icons.

Handling themes (e.g. dark custom themes) is a TODO, but the asset icons don't
handle them either so this is not a regression.

BUG=520623, 575031
TBR=oshima@chromium.org

Committed: https://crrev.com/e5ee6ef233b697aba7475122b8ba48db2b453a2e
Cr-Commit-Position: refs/heads/master@{#368470}
==========

[commit-bot: I haz the power, 2016-01-09 00:10:16]

Patchset 2 (id:??) landed as
https://crrev.com/e5ee6ef233b697aba7475122b8ba48db2b453a2e
Cr-Commit-Position: refs/heads/master@{#368470}