Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1561893002: [Polymer] Roll polymer to latest version (Closed)

Created:
4 years, 11 months ago by imcheng
Modified:
4 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dcheng, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll polymer to latest version. Done by running third_party/polymer/v1_0/reproduce.sh. Fixes compile error found in https://codereview.chromium.org/1521433002/ BUG=none Committed: https://crrev.com/2c36bcb1978cbdf4702b378bbf230f0f373a6340 Cr-Commit-Position: refs/heads/master@{#369338}

Patch Set 1 #

Patch Set 2 : grdp #

Patch Set 3 : update paper-dropdown-menu to 1.1.2 #

Patch Set 4 : Use crisper --script-in-head=false #

Patch Set 5 : update grdp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1091 lines, -747 lines) Patch
M third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/iron-checked-element-behavior-extracted.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/.bower.json View 2 chunks +6 lines, -5 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-dropdown/CONTRIBUTING.md View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/README.md View 1 chunk +41 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/bower.json View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-extracted.js View 6 chunks +46 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-scroll-manager-extracted.js View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/av-icons.html View 4 chunks +22 lines, -7 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/communication-icons.html View 3 chunks +6 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/device-icons.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/editor-icons.html View 3 chunks +7 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/hardware-icons.html View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/image-icons.html View 6 chunks +6 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/index.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/iron-icons.html View 15 chunks +57 lines, -22 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/maps-icons.html View 5 chunks +6 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/notification-icons.html View 2 chunks +6 lines, -2 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-icons/places-icons.html View 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/social-icons.html View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-input/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-input/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-input/iron-input-extracted.js View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/.bower.json View 2 chunks +10 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/bower.json View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-pages/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-pages/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/iron-test-helpers.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/iron-test-helpers-extracted.js View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-test-helpers/mock-interactions.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-test-helpers/test-helpers.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/test-helpers.js View 2 chunks +21 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-drawer-panel/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-drawer-panel/bower.json View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/.bower.json View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/bower.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-extracted.js View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-fab/.bower.json View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-fab/bower.json View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-fab/paper-fab.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-icon-button/.bower.json View 2 chunks +7 lines, -5 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/paper-icon-button/CONTRIBUTING.md View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-icon-button/README.md View 2 chunks +46 lines, -11 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-icon-button/bower.json View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-icon-button/index.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button.html View 1 2 3 3 chunks +9 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/.bower.json View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/README.md View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/bower.json View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/paper-icon-item.html View 1 2 3 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/paper-item.html View 1 2 3 2 chunks +7 lines, -11 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/paper-item-behavior.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/paper-item-behavior-extracted.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/paper-item-body.html View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/paper-item-shared-styles.html View 1 chunk +14 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-material/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-material/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-material/paper-material.html View 1 2 3 2 chunks +2 lines, -25 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/paper-material/paper-material-shared-styles.html View 3 chunks +1 line, -25 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/.bower.json View 2 chunks +9 lines, -6 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/paper-menu-button/CONTRIBUTING.md View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/README.md View 1 chunk +64 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/bower.json View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button.html View 1 2 3 3 chunks +9 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu/README.md View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu/bower.json View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu/paper-menu.html View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu/paper-submenu.html View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu/paper-submenu-extracted.js View 1 chunk +134 lines, -105 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/.bower.json View 2 chunks +9 lines, -10 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/paper-progress/CONTRIBUTING.md View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/README.md View 2 chunks +50 lines, -42 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/bower.json View 2 chunks +7 lines, -8 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/paper-progress.html View 1 2 3 3 chunks +149 lines, -146 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/paper-progress-extracted.js View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/.bower.json View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/bower.json View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-styles/.bower.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-styles/README.md View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-styles/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-styles/classes/typography.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-styles/default-theme.html View 1 chunk +43 lines, -21 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-styles/demo-pages.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-styles/typography.html View 15 chunks +20 lines, -80 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/.bower.json View 2 chunks +13 lines, -11 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/paper-toggle-button/CONTRIBUTING.md View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/README.md View 1 chunk +43 lines, -21 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/bower.json View 2 chunks +11 lines, -9 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/index.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/paper-toggle-button.html View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 2 3 4 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (9 generated)
imcheng
Dan: PTAL thanks!
4 years, 11 months ago (2016-01-06 01:56:47 UTC) #3
imcheng
Uploaded new PS with use of --script-in-head=false and updated grdp, PTAL
4 years, 11 months ago (2016-01-06 19:24:38 UTC) #4
Dan Beam
lgtm let's see how this goes (feel free to try any of the pages you ...
4 years, 11 months ago (2016-01-06 22:12:31 UTC) #5
imcheng
looks good on downloads and media-router
4 years, 11 months ago (2016-01-06 23:12:37 UTC) #6
imcheng
Ok I think I found out what is causing the test failure. tldr: vulcanized code ...
4 years, 11 months ago (2016-01-07 21:23:15 UTC) #7
imcheng
Ping! Please let me know how I can help to move forward with this.
4 years, 11 months ago (2016-01-12 18:34:40 UTC) #8
michaelpg
On 2016/01/12 18:34:40, imcheng1 wrote: > Ping! Please let me know how I can help ...
4 years, 11 months ago (2016-01-12 18:37:48 UTC) #9
michaelpg
On 2016/01/12 18:37:48, michaelpg wrote: > On 2016/01/12 18:34:40, imcheng1 wrote: > > Ping! Please ...
4 years, 11 months ago (2016-01-12 19:19:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561893002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561893002/80001
4 years, 11 months ago (2016-01-13 21:46:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
4 years, 11 months ago (2016-01-13 23:55:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561893002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561893002/80001
4 years, 11 months ago (2016-01-14 01:31:10 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-14 03:41:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561893002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561893002/80001
4 years, 11 months ago (2016-01-14 05:29:23 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-14 05:36:45 UTC) #22
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 05:37:48 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2c36bcb1978cbdf4702b378bbf230f0f373a6340
Cr-Commit-Position: refs/heads/master@{#369338}

Powered by Google App Engine
This is Rietveld 408576698