[Chromecast] Don't export symbols from libffmpeg.a

[Chromecast] Don't export symbols from libffmpeg.a

Use "--exclude-libs" flag to prevent libffmpeg.a from exporting
symbols implemented by assembly.

Assembly functions marked with ".global" directive are automatically
with global visibility and exported in executable and DSO. This is
unnecessary and causes incorrect symbol resolution at run-time as
Chromecast executable is built with "-Wl,--export-dynamic".

BUG= internal b/26390825
TEST= 1) Use "nm" and make sure ff_* are not exported.
      2) Test TuneIn playback.

Committed: https://crrev.com/a39bee512a85a6a015769ced60015a2fe7d3d767
Cr-Commit-Position: refs/heads/master@{#368737}

[wzhong, 2016-01-07 07:19:56]

wzhong@chromium.org changed reviewers:
+ bcf@chromium.org, byungchul@chromium.org, jyw@chromium.org, lcwu@chromium.org,
slan@chromium.org

[slan, 2016-01-07 15:02:14]

lgtm +1

[halliwell, 2016-01-07 15:34:06]

On 2016/01/07 15:02:14, slan wrote:
> lgtm +1

lgtm, you'll need to add an OWNER

[wzhong, 2016-01-07 16:19:01]

Description was changed from

==========
[Chromecast] Don't export symbols from libffmpeg.a

Use "--exclude-libs" flag to prevent libffmpeg.a from exporting
symbols implemented by assembly.

Assembly functions marked with ".global" directive are automatically
with global visibility and exported in executable and DSO. This is
unnecessary and causes incorrect symbol resolution at run-time as
Chromecast executable is built with "-Wl,--export-dynamic".

BUG= internal b/26390825
TEST= 1) Use "nm" and make sure ff_* are not exported.
      2) Test TuneIn playback.
==========

to

==========
[Chromecast] Don't export symbols from libffmpeg.a

Use "--exclude-libs" flag to prevent libffmpeg.a from exporting
symbols implemented by assembly.

Assembly functions marked with ".global" directive are automatically
with global visibility and exported in executable and DSO. This is
unnecessary and causes incorrect symbol resolution at run-time as
Chromecast executable is built with "-Wl,--export-dynamic".

BUG= internal b/26390825
TEST= 1) Use "nm" and make sure ff_* are not exported.
      2) Test TuneIn playback.
==========

[wzhong, 2016-01-07 16:19:01]

wzhong@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org

[wzhong, 2016-01-07 23:42:38]

Friendly ping to OWNER.

We have a push that is currently blocked by this CL...

[brettw, 2016-01-11 23:20:58]

owners LGTM for build/config

[wzhong, 2016-01-11 23:21:32]

The CQ bit was checked by wzhong@chromium.org

[commit-bot: I haz the power, 2016-01-11 23:23:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1561833007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1561833007/1

[commit-bot: I haz the power, 2016-01-12 00:42:18]

Description was changed from

==========
[Chromecast] Don't export symbols from libffmpeg.a

Use "--exclude-libs" flag to prevent libffmpeg.a from exporting
symbols implemented by assembly.

Assembly functions marked with ".global" directive are automatically
with global visibility and exported in executable and DSO. This is
unnecessary and causes incorrect symbol resolution at run-time as
Chromecast executable is built with "-Wl,--export-dynamic".

BUG= internal b/26390825
TEST= 1) Use "nm" and make sure ff_* are not exported.
      2) Test TuneIn playback.
==========

to

==========
[Chromecast] Don't export symbols from libffmpeg.a

Use "--exclude-libs" flag to prevent libffmpeg.a from exporting
symbols implemented by assembly.

Assembly functions marked with ".global" directive are automatically
with global visibility and exported in executable and DSO. This is
unnecessary and causes incorrect symbol resolution at run-time as
Chromecast executable is built with "-Wl,--export-dynamic".

BUG= internal b/26390825
TEST= 1) Use "nm" and make sure ff_* are not exported.
      2) Test TuneIn playback.
==========

[commit-bot: I haz the power, 2016-01-12 00:42:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-12 00:44:02]

Description was changed from

==========
[Chromecast] Don't export symbols from libffmpeg.a

Use "--exclude-libs" flag to prevent libffmpeg.a from exporting
symbols implemented by assembly.

Assembly functions marked with ".global" directive are automatically
with global visibility and exported in executable and DSO. This is
unnecessary and causes incorrect symbol resolution at run-time as
Chromecast executable is built with "-Wl,--export-dynamic".

BUG= internal b/26390825
TEST= 1) Use "nm" and make sure ff_* are not exported.
      2) Test TuneIn playback.
==========

to

==========
[Chromecast] Don't export symbols from libffmpeg.a

Use "--exclude-libs" flag to prevent libffmpeg.a from exporting
symbols implemented by assembly.

Assembly functions marked with ".global" directive are automatically
with global visibility and exported in executable and DSO. This is
unnecessary and causes incorrect symbol resolution at run-time as
Chromecast executable is built with "-Wl,--export-dynamic".

BUG= internal b/26390825
TEST= 1) Use "nm" and make sure ff_* are not exported.
      2) Test TuneIn playback.

Committed: https://crrev.com/a39bee512a85a6a015769ced60015a2fe7d3d767
Cr-Commit-Position: refs/heads/master@{#368737}
==========

[commit-bot: I haz the power, 2016-01-12 00:44:03]

Patchset 1 (id:??) landed as
https://crrev.com/a39bee512a85a6a015769ced60015a2fe7d3d767
Cr-Commit-Position: refs/heads/master@{#368737}