runtime/vm/dart_api_impl_test.cc - Issue 1561833006: Improve token position for the entry CheckStackoverflowInstr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 1561833006: Improve token position for the entry CheckStackoverflowInstr (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl_test.cc

diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc

index 3cbf287d699d00185c127555a576243920e75ae8..591373ab4e2f4fd9d7ecfa41df706bc4b520f315 100644

--- a/runtime/vm/dart_api_impl_test.cc

+++ b/runtime/vm/dart_api_impl_test.cc

@@ -254,7 +254,7 @@ TEST_CASE(StackOverflowStacktraceInfo) {

Dart_StringToCString(script_url, &cstr);

EXPECT_STREQ("test-lib", cstr);

EXPECT_EQ(2, line_number);

- EXPECT_EQ(3, column_number);

+ EXPECT_EQ(13, column_number);

// Out-of-bounds frames.

result = Dart_GetActivationFrame(stacktrace, frame_count, &frame);

« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »