Issue 1561833006: Improve token position for the entry CheckStackoverflowInstr

Issue 1561833006: Improve token position for the entry CheckStackoverflowInstr (Closed)

Created:
4 years, 11 months ago by Cutch

Modified:
4 years, 11 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Improve token position for the entry CheckStackoverflowInstr - Have it use the same token position as the DebugStepCheckInstr at entry. - Add a token pos to ConstantInstr (but it's not really used yet). R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/89d05debeccbebc36b8844f755a53458c2e2c9fc

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
M	runtime/vm/dart_api_impl_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 6 (3 generated)

Cutch

4 years, 11 months ago (2016-01-06 19:21:04 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
89d05debeccbebc36b8844f755a53458c2e2c9fc (presubmit successful).