chrome/browser/resources/chromeos/chromevox/common/composite_tts.js - Issue 1561773002: Implement ChromeVox Next menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/composite_tts.js

Issue 1561773002: Implement ChromeVox Next menus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@panel_view_type

Patch Set: Address feedback Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/common/command_store.js ('K') | « chrome/browser/resources/chromeos/chromevox/common/command_store.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js » ('j') | chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/common/composite_tts.js

diff --git a/chrome/browser/resources/chromeos/chromevox/common/composite_tts.js b/chrome/browser/resources/chromeos/chromevox/common/composite_tts.js

index bba284015256a5495b5da0855ec469d62e7dbbc4..5add8fea63cc511fac21d26043d2d5676f1e51ac 100644

--- a/chrome/browser/resources/chromeos/chromevox/common/composite_tts.js

+++ b/chrome/browser/resources/chromeos/chromevox/common/composite_tts.js

@@ -93,6 +93,19 @@ cvox.CompositeTts.prototype.increaseOrDecreaseProperty =

/**

* @override

+cvox.CompositeTts.prototype.propertyToPercentage = function(property) {

+ for (var i = 0, engine; engine = this.ttsEngines_[i]; i++) {

+ var value = engine.propertyToPercentage(property);

+ if (value) {

David Tseng 2016/01/12 20:10:57 if (value !== undefined) or typeof(value) == 'numb

dmazzoni 2016/01/13 23:26:39 Done.

+ return value;

+ }

+};

+/**

+ * @override

+ */

cvox.CompositeTts.prototype.getDefaultProperty = function(property) {

for (var i = 0, engine; engine = this.ttsEngines_[i]; i++) {

var value = engine.getDefaultProperty(property);