Implement ChromeVox Next menus.

Implement ChromeVox Next menus.

Open the menus by pressing Search+Period or by clicking on the icon in the
panel. Select an item with the mouse or arrow keys.

Everything with a key binding and category appears in the menus by default.
Also adds all open tabs to the menus.

The feedback when the menu first opens isn't always right, this will be
fixed when we get better focus tracking.

BUG=513717
Committed: https://crrev.com/429446698446a103171801d827c5dab5f98baa1c
Cr-Commit-Position: refs/heads/master@{#373852}

[dmazzoni, 2016-01-05 22:38:35]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org, plundblad@chromium.org

[David Tseng, 2016-01-08 21:39:33]

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json
(right):

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json:4:
"command": "previousObject",
You'll have to change these in the manifest as well.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:492:
break;
Needs to announce the percentage (same with all of these below).

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:717:
*
?

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:721:
var containingWindow = this.savedRange_.start.node;
Rename to containingWebView?

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:725:
if (containingWindow) {
nit: remove braces

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
(right):

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js:60:
console.log(evt.type + ' on ' + node.role + ' ' + node.name);
nit: remove

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
(right):

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:53: *
@type {?PanelMenu}
Object types are nullable by default right?

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:59: * If
the menu button in the panel is enabled at all. It's disabled if
True if ...?

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:216: //
top-level menus. Some categories aren't mapped to any menu.
Do the non-categorized options get placed in the top level of the menu?

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:217: var
categoryToMenu = {
Could promote this to an assigned var of Panel.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:232: var
keymap = bkgnd['cvox']['ChromeVoxKbHandler']['handlerKeyMap'];
You could also use cvox.KeyMap.fromCurrent.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:279:
tabsMenu.addMenuItem(tabs[j].title, '', (function(win, tab) {
It would be nice to include whether a tab was current (focused) in the title.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:364:
activeIndex = (activeIndex + this.menus_.length) % this.menus_.length;
Can't you just do:
activeIndex %= this.menus_.length;

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
(right):

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js:67: *
@return {PanelMenuItem} The menu item just created.
!panelMenuItem.

[dmazzoni, 2016-01-11 22:04:06]

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json
(right):

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json:4:
"command": "previousObject",
On 2016/01/08 21:39:32, David Tseng wrote:
> You'll have to change these in the manifest as well.

OK, done. Most of the other commands aren't in the manifest, should we add them?

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:492:
break;
On 2016/01/08 21:39:32, David Tseng wrote:
> Needs to announce the percentage (same with all of these below).

Done.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:717:
*
On 2016/01/08 21:39:32, David Tseng wrote:
> ?

Done.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:721:
var containingWindow = this.savedRange_.start.node;
On 2016/01/08 21:39:32, David Tseng wrote:
> Rename to containingWebView?

Done.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:725:
if (containingWindow) {
On 2016/01/08 21:39:32, David Tseng wrote:
> nit: remove braces

Done.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
(right):

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js:60:
console.log(evt.type + ' on ' + node.role + ' ' + node.name);
On 2016/01/08 21:39:32, David Tseng wrote:
> nit: remove

Done.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
(right):

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:53: *
@type {?PanelMenu}
On 2016/01/08 21:39:33, David Tseng wrote:
> Object types are nullable by default right?

Done.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:59: * If
the menu button in the panel is enabled at all. It's disabled if
On 2016/01/08 21:39:33, David Tseng wrote:
> True if ...?

Done.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:216: //
top-level menus. Some categories aren't mapped to any menu.
On 2016/01/08 21:39:33, David Tseng wrote:
> Do the non-categorized options get placed in the top level of the menu?

No, the top-level menus are hard-coded in the code, and then we map some of the
categories to those top-level menus.

This should be fine because there are a few commands that are developer-only
that we don't necessarily want in the menus. We should audit all of these at
some point.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:217: var
categoryToMenu = {
On 2016/01/08 21:39:33, David Tseng wrote:
> Could promote this to an assigned var of Panel.

Not easily because the mapping goes to PanelMenu objects just created above, and
those are recreated dynamically each time you open the menus.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:232: var
keymap = bkgnd['cvox']['ChromeVoxKbHandler']['handlerKeyMap'];
On 2016/01/08 21:39:32, David Tseng wrote:
> You could also use cvox.KeyMap.fromCurrent.

Done.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:279:
tabsMenu.addMenuItem(tabs[j].title, '', (function(win, tab) {
On 2016/01/08 21:39:33, David Tseng wrote:
> It would be nice to include whether a tab was current (focused) in the title.

Done.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:364:
activeIndex = (activeIndex + this.menus_.length) % this.menus_.length;
On 2016/01/08 21:39:32, David Tseng wrote:
> Can't you just do:
> activeIndex %= this.menus_.length;

That wouldn't work with negative numbers. We want to map -1 to length - 1.

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
(right):

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js:67: *
@return {PanelMenuItem} The menu item just created.
On 2016/01/08 21:39:33, David Tseng wrote:
> !panelMenuItem.

Done.

[David Tseng, 2016-01-12 19:24:42]

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json
(right):

https://codereview.chromium.org/1561773002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json:4:
"command": "previousObject",
On 2016/01/11 22:04:06, dmazzoni wrote:
> On 2016/01/08 21:39:32, David Tseng wrote:
> > You'll have to change these in the manifest as well.
> 
> OK, done. Most of the other commands aren't in the manifest, should we add
them?

Yes though we're pretty constrained in the types of keys we can reserve. Let's
chat about it when we meet.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:395:
case 'jumpToTop':
goToEnd/jumpToBottom as well?

[David Tseng, 2016-01-12 20:10:57]

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/common/command_store.js
(right):

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/common/command_store.js:156:
category: 'modifier_keys'},
Curious, why recatgorize?

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/common/composite_tts.js
(right):

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/common/composite_tts.js:99: if
(value) {
if (value !== undefined) or typeof(value) == 'number'

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:245:
}
nit: remove braces

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:748:
}
nit: remove braces

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:750:
containingWebView.focus();
Does this restore focus properly? What if savedRange_ no longer exists in the
page?

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
(right):

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:243:
console.log('No localization for: ' + command);
.error

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:358:
Panel.advanceActiveMenuBy = function(delta) {
Really optional but I was thinking this would be a good case for using data
bindings. Object.observe on a tree-like array representation with each entry
being a menu entry or submenu entry. Totally passing thought.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:425: case
'Right':
Are there submenus?

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:441:
break;
Are we thinking about supporting auto complete/type ahead?

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
(right):

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js:40: *
@type Array<PanelMenuItem>
Invalid js doc? @type {!A...}

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js:142:
}
nit: remove braces

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js:181:
for (var i = 0; i < this.items_.length; i++) {
Can use: this.items_.find

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu_item.js
(right):

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu_item.js:18:
this.callback = callback;
js doc

[dmazzoni, 2016-01-13 23:26:40]

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/common/command_store.js
(right):

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/common/command_store.js:156:
category: 'modifier_keys'},
On 2016/01/12 20:10:57, David Tseng wrote:
> Curious, why recatgorize?

Changed back. I think at one point either controlling_speech or modifier_keys
wasn't going to be in the menus, but now they both are.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/common/composite_tts.js
(right):

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/common/composite_tts.js:99: if
(value) {
On 2016/01/12 20:10:57, David Tseng wrote:
> if (value !== undefined) or typeof(value) == 'number'

Done.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:245:
}
On 2016/01/12 20:10:57, David Tseng wrote:
> nit: remove braces

Done.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:395:
case 'jumpToTop':
On 2016/01/12 19:24:42, David Tseng wrote:
> goToEnd/jumpToBottom as well?

Done.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:748:
}
On 2016/01/12 20:10:57, David Tseng wrote:
> nit: remove braces

Done.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:750:
containingWebView.focus();
On 2016/01/12 20:10:57, David Tseng wrote:
> Does this restore focus properly? What if savedRange_ no longer exists in the
> page?

It's okay to call focus() on a dead node, it's a no-op. Worst case this does
nothing and we sync state again when focus is restored.

As we fix focus handling we can try to improve on this.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
(right):

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:243:
console.log('No localization for: ' + command);
On 2016/01/12 20:10:57, David Tseng wrote:
> .error

Done.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:358:
Panel.advanceActiveMenuBy = function(delta) {
On 2016/01/12 20:10:57, David Tseng wrote:
> Really optional but I was thinking this would be a good case for using data
> bindings. Object.observe on a tree-like array representation with each entry
> being a menu entry or submenu entry. Totally passing thought.

Sure, let's explore that as a follow-up.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:425: case
'Right':
On 2016/01/12 20:10:57, David Tseng wrote:
> Are there submenus?

Not currently.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:441:
break;
On 2016/01/12 20:10:57, David Tseng wrote:
> Are we thinking about supporting auto complete/type ahead?

Yes, that'd be great. We should talk about what behavior would make the most
sense.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
(right):

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js:40: *
@type Array<PanelMenuItem>
On 2016/01/12 20:10:57, David Tseng wrote:
> Invalid js doc? @type {!A...}

Done.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js:142:
}
On 2016/01/12 20:10:57, David Tseng wrote:
> nit: remove braces

Done.

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js:181:
for (var i = 0; i < this.items_.length; i++) {
On 2016/01/12 20:10:57, David Tseng wrote:
> Can use: this.items_.find

Not any cleaner in this case because it returns the item, we still need to
extract the callback from that.

[David Tseng, 2016-01-14 03:14:00]

lgtm

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
(right):

https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:441:
break;
On 2016/01/13 23:26:40, dmazzoni wrote:
> On 2016/01/12 20:10:57, David Tseng wrote:
> > Are we thinking about supporting auto complete/type ahead?
> 
> Yes, that'd be great. We should talk about what behavior would make the most
> sense.

Maybe something like the current keyboard help; basically the same experience as
incremental search.

[dmazzoni, 2016-01-21 22:41:46]

On 2016/01/14 03:14:00, David Tseng wrote:
> lgtm
> 
>
https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
> (right):
> 
>
https://codereview.chromium.org/1561773002/diff/20001/chrome/browser/resource...
> chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:441:
> break;
> On 2016/01/13 23:26:40, dmazzoni wrote:
> > On 2016/01/12 20:10:57, David Tseng wrote:
> > > Are we thinking about supporting auto complete/type ahead?
> > 
> > Yes, that'd be great. We should talk about what behavior would make the most
> > sense.
> 
> Maybe something like the current keyboard help; basically the same experience
as
> incremental search.

The alternative would be for it to behave more like a OS menu bar, where each
menu item has an accelerator.

[dmazzoni, 2016-01-21 22:42:07]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-01-21 22:42:08]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/1561773002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-01-21 22:43:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1561773002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1561773002/60001

[commit-bot: I haz the power, 2016-01-21 23:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 23:38:27]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2016-02-04 22:03:48]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-02-04 22:03:49]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/1561773002/#ps80001
(title: "Rebase, fix tests")

[commit-bot: I haz the power, 2016-02-04 22:07:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1561773002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1561773002/80001

[commit-bot: I haz the power, 2016-02-04 23:37:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 23:37:13]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2016-02-05 17:14:43]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-02-05 17:14:44]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/1561773002/#ps100001
(title: "Fix Ozone by only activating panel when fullscreen")

[commit-bot: I haz the power, 2016-02-05 17:16:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1561773002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1561773002/100001

[commit-bot: I haz the power, 2016-02-05 18:21:51]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-05 18:23:21]

Description was changed from

==========
Implement ChromeVox Next menus.

Open the menus by pressing Search+Period or by clicking on the icon in the
panel. Select an item with the mouse or arrow keys.

Everything with a key binding and category appears in the menus by default.
Also adds all open tabs to the menus.

The feedback when the menu first opens isn't always right, this will be
fixed when we get better focus tracking.

BUG=513717
==========

to

==========
Implement ChromeVox Next menus.

Open the menus by pressing Search+Period or by clicking on the icon in the
panel. Select an item with the mouse or arrow keys.

Everything with a key binding and category appears in the menus by default.
Also adds all open tabs to the menus.

The feedback when the menu first opens isn't always right, this will be
fixed when we get better focus tracking.

BUG=513717

Committed: https://crrev.com/429446698446a103171801d827c5dab5f98baa1c
Cr-Commit-Position: refs/heads/master@{#373852}
==========

[commit-bot: I haz the power, 2016-02-05 18:23:23]

Patchset 6 (id:??) landed as
https://crrev.com/429446698446a103171801d827c5dab5f98baa1c
Cr-Commit-Position: refs/heads/master@{#373852}

[tommycli, 2016-02-09 18:58:31]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1684693002/ by tommycli@chromium.org.

The reason for reverting is: Speculatively reverting to fix interactive_ui_test
failures starting here: 

https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...

TestAsNormalAndGuestUser_SpokenFeedbackTest.NavigateAppLauncher_1

This patch was committed in the preceding build (here) but the flake wasn't
detected until the next build.

https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...
.