Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1561753002: In Google3 build, use SK_SFNTLY_SUBSETTER define to enable/disable sfntly. (Closed)

Created:
4 years, 11 months ago by dogben
Modified:
4 years, 11 months ago
Reviewers:
mtklein
CC:
reviews_skia.org, jcgregorio
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

In Google3 build, use SK_SFNTLY_SUBSETTER define to enable/disable sfntly. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1561753002 Committed: https://skia.googlesource.com/skia/+/bc348f41a7d51ba2385ca1d2d2ffab3657559d16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M BUILD.public View 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561753002/1
4 years, 11 months ago (2016-01-05 22:15:55 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-05 22:32:31 UTC) #5
dogben
4 years, 11 months ago (2016-01-05 23:47:04 UTC) #7
mtklein
lgtm oh that's so much better
4 years, 11 months ago (2016-01-06 00:59:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561753002/1
4 years, 11 months ago (2016-01-06 00:59:19 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 01:00:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bc348f41a7d51ba2385ca1d2d2ffab3657559d16

Powered by Google App Engine
This is Rietveld 408576698