Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: lib/src/executable.dart

Issue 1561743002: Work around dart-lang/sdk#25348. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/executable.dart
diff --git a/lib/src/executable.dart b/lib/src/executable.dart
index 83880392dfb02f8828d8215ebf3cc4636735d506..7f9a9ae22902c2fa591fe7c8c96dd9e2e49dd3a8 100644
--- a/lib/src/executable.dart
+++ b/lib/src/executable.dart
@@ -141,7 +141,10 @@ Future<int> runExecutable(Entrypoint entrypoint, String package,
process.stdout.listen(stdout.add);
stdin.listen(process.stdin.add);
- return process.exitCode;
+ // Work around dart-lang/sdk#25348.
+ process.stdin.done.catchError((_) {});
+
+ return await process.exitCode;
}
/// Returns the URL the VM should use to load the executable at [path].
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698