Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 156173005: Create a common utility for finding and running binaries in out/ (Closed)

Created:
6 years, 10 months ago by rmistry
Modified:
6 years, 10 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Create a common utility for finding and running binaries in out/ NOTRY=true BUG=skia:2019 Committed: http://code.google.com/p/skia/source/detail?r=13367

Patch Set 1 #

Patch Set 2 : Lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -21 lines) Patch
A tools/find_run_binary.py View 1 chunk +61 lines, -0 lines 0 comments Download
M tools/tests/base_unittest.py View 1 3 chunks +8 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmistry
6 years, 10 months ago (2014-02-07 18:00:10 UTC) #1
epoger
lgtm
6 years, 10 months ago (2014-02-07 18:40:48 UTC) #2
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 10 months ago (2014-02-07 18:41:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rmistry@google.com/156173005/30001
6 years, 10 months ago (2014-02-07 18:41:44 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 18:41:52 UTC) #5
Message was sent while issue was closed.
Change committed as 13367

Powered by Google App Engine
This is Rietveld 408576698