Abstract IPC send out of PasswordGenerationManager

Abstract IPC send out of PasswordGenerationManager

The IPC in question was in
PasswordGenerationManager::SendAccountCreationFormsToRenderer. This is now done
through PasswordManagerDriver.

Most of this patch was developed by vabr@chromium.org.

BUG=335028
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252063

[blundell, 2014-02-07 14:55:08]

Hi Garrett,

I'm inclined to leave the creation of standalone TestPasswordManagerDriver and
TestPasswordManagerDelegate files for a follow-up CL when some more of the dust
has cleared. WDYT?

[vabr (Chromium), 2014-02-10 08:04:28]

LGTM, Thanks! Leaving the test delegate and driver in the unit test seems
reasonable to me until the moment when we need them in another test.
Let's see what Garrett says.
Cheers,
Vaclav

[blundell, 2014-02-11 10:38:19]

On 2014/02/10 08:04:28, vabr (Chromium) wrote:
> LGTM, Thanks! Leaving the test delegate and driver in the unit test seems
> reasonable to me until the moment when we need them in another test.
> Let's see what Garrett says.
> Cheers,
> Vaclav

Garrett: Ping :).

[Garrett Casto, 2014-02-11 18:14:28]

Sorry, got lost in the shuffle when I got back. LGTM.

[blundell, 2014-02-11 20:25:14]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-02-11 20:28:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/156173004/1

[commit-bot: I haz the power, 2014-02-11 20:28:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-11 20:28:18]

Failed to apply patch for
chrome/browser/password_manager/content_password_manager_driver.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/password_manager/content_password_manager_driver.h
  Hunk #1 FAILED at 24.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/password_manager/content_password_manager_driver.h.rej

Patch:       chrome/browser/password_manager/content_password_manager_driver.h
Index: chrome/browser/password_manager/content_password_manager_driver.h
diff --git a/chrome/browser/password_manager/content_password_manager_driver.h
b/chrome/browser/password_manager/content_password_manager_driver.h
index
60f8e8750f66fd4783e456a1c3467afa67037ba8..cd4e8a10a69d8b51b1de260085cfc79718f9d073
100644
--- a/chrome/browser/password_manager/content_password_manager_driver.h
+++ b/chrome/browser/password_manager/content_password_manager_driver.h
@@ -24,8 +24,8 @@ class WebContents;
 class ContentPasswordManagerDriver : public PasswordManagerDriver,
                                      public content::WebContentsObserver {
  public:
-  explicit ContentPasswordManagerDriver(content::WebContents* web_contents,
-                                        PasswordManagerDelegate* delegate);
+  ContentPasswordManagerDriver(content::WebContents* web_contents,
+                               PasswordManagerDelegate* delegate);
   virtual ~ContentPasswordManagerDriver();
 
   // PasswordManagerDriver implementation.
@@ -38,6 +38,8 @@ class ContentPasswordManagerDriver : public
PasswordManagerDriver,
   virtual autofill::AutofillManager* GetAutofillManager() OVERRIDE;
   virtual void AllowPasswordGenerationForForm(autofill::PasswordForm* form)
       OVERRIDE;
+  virtual void AccountCreationFormsFound(
+      const std::vector<autofill::FormData>& forms) OVERRIDE;
 
   // content::WebContentsObserver overrides.
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

[blundell, 2014-02-11 21:03:36]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-02-11 21:04:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/156173004/240001

[commit-bot: I haz the power, 2014-02-11 21:33:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/156173004/240001

[commit-bot: I haz the power, 2014-02-11 22:11:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/156173004/240001

[commit-bot: I haz the power, 2014-02-11 23:06:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-11 23:06:10]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[blundell, 2014-02-12 13:46:41]

Hi Garrett,

I hadn't realized that I needed to adjust the PasswordGenerationManager
unittests. Could you take at the diff on password_generation_manager_unittest.cc
in PS4? Thanks!

[blundell, 2014-02-18 20:31:45]

Hi Garrett,

Polite ping in case this slipped off your radar during vacation :).

Thanks,

Colin

[Garrett Casto, 2014-02-18 21:19:29]

lgtm

https://codereview.chromium.org/156173004/diff/740001/chrome/browser/password...
File chrome/browser/password_manager/password_generation_manager_unittest.cc
(right):

https://codereview.chromium.org/156173004/diff/740001/chrome/browser/password...
chrome/browser/password_manager/password_generation_manager_unittest.cc:28:
class TestPasswordManagerDriver : public PasswordManagerDriver {
At some point we might want to make one Test/Mock implementation of the manager
and the driver.  Doesn't need to block this now.

https://codereview.chromium.org/156173004/diff/740001/chrome/browser/password...
chrome/browser/password_manager/password_generation_manager_unittest.cc:145:
class IncognitoPasswordGenerationManagerTest :
Looks like having a separate class for this is no longer necessary, since we
aren't getting OTR state directly from a profile.

[blundell, 2014-02-19 13:27:21]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-02-19 13:27:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/156173004/820001

[blundell, 2014-02-19 13:28:10]

https://codereview.chromium.org/156173004/diff/740001/chrome/browser/password...
File chrome/browser/password_manager/password_generation_manager_unittest.cc
(right):

https://codereview.chromium.org/156173004/diff/740001/chrome/browser/password...
chrome/browser/password_manager/password_generation_manager_unittest.cc:145:
class IncognitoPasswordGenerationManagerTest :
On 2014/02/18 21:19:29, Garrett Casto wrote:
> Looks like having a separate class for this is no longer necessary, since we
> aren't getting OTR state directly from a profile.

Done.

[commit-bot: I haz the power, 2014-02-19 15:02:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/156173004/820001

[commit-bot: I haz the power, 2014-02-19 15:29:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/156173004/820001

[commit-bot: I haz the power, 2014-02-19 20:23:44]

Change committed as 252063