Issue 156173003: Remove unused parts of MediaControllerInterface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 156173003: Remove unused parts of MediaControllerInterface (Closed)

Created:
6 years, 10 months ago by philipj_slow

Modified:
6 years, 10 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove unused parts of MediaControllerInterface Remove the parts of MediaControllerInterface that aren't actually used by the MediaControls code, which is the only place where this abstract interface is used as opposed to HTMLMediaElement or MediaController. hasCurrentSrc() wasn't used anywhere, so remove it. BUG=341852 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166766

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -46 lines)			Patch
M	Source/core/html/HTMLMediaElement.h	View	4 chunks	+8 lines, -9 lines	0 comments	Download
M	Source/core/html/MediaController.h	View	4 chunks	+7 lines, -10 lines	0 comments	Download
M	Source/core/html/MediaController.cpp	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	Source/core/html/MediaControllerInterface.h	View	3 chunks	+1 line, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

Part 2, depends on https://codereview.chromium.org/154283004/ The third step will be to move what remains of ...

6 years, 10 months ago (2014-02-07 13:39:04 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/156173003/1

6 years, 10 months ago (2014-02-08 08:07:47 UTC) #4

Message was sent while issue was closed.

Change committed as 166766

Expand Messages | Collapse Messages