Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 156173002: [MIDI] Add a permission bubble client for MIDI system control. (Closed)

Created:
6 years, 10 months ago by Greg Billock
Modified:
6 years, 10 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

[MIDI] Add a permission bubble client for MIDI system control. BUG=332115 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250820

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Total comments: 18

Patch Set 4 : tweaks #

Total comments: 4

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -9 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/media/chrome_midi_permission_context.h View 1 2 3 3 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/media/chrome_midi_permission_context.cc View 1 2 3 5 chunks +99 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Greg Billock
6 years, 10 months ago (2014-02-06 19:41:43 UTC) #1
Ami GONE FROM CHROMIUM
I don't know anything about Chrome MIDI; you should get a review from a MIDI ...
6 years, 10 months ago (2014-02-06 19:51:17 UTC) #2
Greg Billock
https://codereview.chromium.org/156173002/diff/60001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/156173002/diff/60001/chrome/app/generated_resources.grd#newcode13296 chrome/app/generated_resources.grd:13296: + fully control your MIDI devices. On 2014/02/06 19:51:17, ...
6 years, 10 months ago (2014-02-07 18:20:55 UTC) #3
Ami GONE FROM CHROMIUM
LGTM % nits & a review from someone who knows the MIDI code. https://codereview.chromium.org/156173002/diff/60001/chrome/browser/media/chrome_midi_permission_context.cc File ...
6 years, 10 months ago (2014-02-07 18:25:34 UTC) #4
Greg Billock
https://codereview.chromium.org/156173002/diff/60001/chrome/browser/media/chrome_midi_permission_context.cc File chrome/browser/media/chrome_midi_permission_context.cc (right): https://codereview.chromium.org/156173002/diff/60001/chrome/browser/media/chrome_midi_permission_context.cc#newcode83 chrome/browser/media/chrome_midi_permission_context.cc:83: return l10n_util::GetStringUTF16(IDS_MIDI_SYSEX_DENY_BUTTON); On 2014/02/07 18:25:34, Ami Fischman wrote: > ...
6 years, 10 months ago (2014-02-10 23:57:09 UTC) #5
Takashi Toyoshima
Thank you for working on this. I'm not sure how this new grd text, IDS_MIDI_SYSEX_PERMISSION_FRAGMENT, ...
6 years, 10 months ago (2014-02-12 07:29:37 UTC) #6
Greg Billock
Thanks. Here's a screenshot, which doesn't show this prompt, but other parallel fragments. Also, this ...
6 years, 10 months ago (2014-02-12 18:19:48 UTC) #7
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 10 months ago (2014-02-12 18:19:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/156173002/180001
6 years, 10 months ago (2014-02-12 18:21:40 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 22:56:52 UTC) #10
Message was sent while issue was closed.
Change committed as 250820

Powered by Google App Engine
This is Rietveld 408576698