url/url_canon_icu.cc - Issue 1561693003: IWYU fixes for url/...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/url_canon_icu.cc

Issue 1561693003: IWYU fixes for url/... Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added IWYU-pragma-keep in a few places. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: url/url_canon_icu.cc

diff --git a/url/url_canon_icu.cc b/url/url_canon_icu.cc

index d0468cccaf13176b66350f0558d34727ebf7500f..5d7f80578c48d2555a9cddddab01d13b463b6dbd 100644

--- a/url/url_canon_icu.cc

+++ b/url/url_canon_icu.cc

@@ -4,15 +4,20 @@

// ICU integration functions.

+#include <stdbool.h>

dcheng 2016/01/07 00:25:41 This is needed in a C++ translation unit? That's r

Łukasz Anforowicz 2016/01/07 00:44:53 Errr... don't shoot the messenger, but iwyu.out sa

#include <stdint.h>

#include <stdlib.h>

#include <string.h>

+#include <ostream>

#include "base/lazy_instance.h"

#include "base/logging.h"

#include "third_party/icu/source/common/unicode/ucnv.h"

#include "third_party/icu/source/common/unicode/ucnv_cb.h"

#include "third_party/icu/source/common/unicode/uidna.h"

+#include "third_party/icu/source/common/unicode/umachine.h"

+#include "third_party/icu/source/common/unicode/urename.h"

+#include "third_party/icu/source/common/unicode/utypes.h"

#include "url/url_canon_icu.h"

#include "url/url_canon_internal.h" // for _itoa_s