url/gurl.h - Issue 1561693003: IWYU fixes for url/...

Unified Diff: url/gurl.h

Issue 1561693003: IWYU fixes for url/... Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added IWYU-pragma-keep in a few places. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: url/gurl.h

diff --git a/url/gurl.h b/url/gurl.h

index b49d2fdb1c618ff20482eaf702949f86a9c112b1..a26dff656197c4f2132211b9befab4d733427b2e 100644

--- a/url/gurl.h

+++ b/url/gurl.h

@@ -6,7 +6,6 @@

#define URL_GURL_H_

#include <stddef.h>

Avi (use Gerrit) 2016/01/07 01:11:03 :( Can we not lose these newlines? There's a disc

dcheng 2016/01/07 01:20:49 The discussion on C-style seems to indicate lean i

#include <iosfwd>

#include <string>

@@ -19,6 +18,10 @@

#include "url/url_constants.h"

#include "url/url_export.h"

+namespace url {

+template <typename CHAR> class Replacements;

+} // namespace url

dcheng 2016/01/07 00:25:41 I'm not super familiar with IWYU: I guess it also

Łukasz Anforowicz 2016/01/07 00:44:53 Right. Although in this case I am surprised by th

Nico 2016/01/08 00:34:26 I think in general iwyu doesn't work super well –

Łukasz Anforowicz 2016/01/08 17:26:41 Thanks for the reference - I've added the link to

// Represents a URL.

// A parsed canonicalized URL will be guaranteed UTF-8. Only the ref (if

« no previous file with comments | « url/DEPS ('k') | url/gurl.cc » ('j') | url/url_canon_fileurl.cc » ('J')