IWYU fixes for url/...

url/url_canon_fileurl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Functions for canonicalizing "file:" URLs.
 
+#include "base/strings/string16.h"
+#include "url/third_party/mozilla/url_parse.h"
 #include "url/url_canon.h"
 #include "url/url_canon_internal.h"
-#include "url/url_file.h"
-#include "url/url_parse_internal.h"
+#include "url/url_file.h"  // IWYU pragma: keep

[dcheng, 2016/01/07 00:25:41]

Having to do this seems like a net negative. Have you tried running it across
something like //base? How well does it deal with stuff that includes
platform-specific includes?

[Łukasz Anforowicz, 2016/01/07 00:44:53]

Yes, but I haven't looked at the results.
Probably not well :-/

Options?:
- Not use IWYU for directories with platform-specific stuff
- Manually fix mistakes and sprinkle IWYU-keep-pragmas over the code
- Build + run IWYU on Linux + Windows and somehow merge results (probably too
much effort?)

+#include "url/url_parse_internal.h"  // IWYU pragma: keep
 
 namespace url {
 
 namespace {
 
 #ifdef WIN32
 
 // Given a pointer into the spec, this copies and canonicalizes the drive
 // letter and colon to the output, if one is found. If there is not a drive
 // spec, it won't do anything. The index of the next character in the input
@@ skipping 159 matching lines @@
                     Parsed* new_parsed) {
   RawCanonOutput<1024> utf8;
   URLComponentSource<char> source(base);
   Parsed parsed(base_parsed);
   SetupUTF16OverrideComponents(base, replacements, &utf8, &source, &parsed);
   return DoCanonicalizeFileURL<char, unsigned char>(
       source, parsed, query_converter, output, new_parsed);
 }
 
 }  // namespace url