IWYU fixes for url/...

url/gurl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef URL_GURL_H_
 #define URL_GURL_H_
 
 #include <stddef.h>
-

[Avi (use Gerrit), 2016/01/07 01:11:03]

:(

Can we not lose these newlines? There's a discussion on c-style about that.

[dcheng, 2016/01/07 01:20:49]

The discussion on C-style seems to indicate lean in favor of not fighting the
tools (ClangMR, IWYU). Given that the style guide does not have a hard
requirement around this, I don't see a good reason to not conform.

 #include <iosfwd>
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_piece.h"
 #include "url/third_party/mozilla/url_parse.h"
 #include "url/url_canon.h"
 #include "url/url_canon_stdstring.h"
 #include "url/url_constants.h"
 #include "url/url_export.h"
 
+namespace url {
+template <typename CHAR> class Replacements;
+}  // namespace url

[dcheng, 2016/01/07 00:25:41]

I'm not super familiar with IWYU: I guess it also adds forward declares?

[Łukasz Anforowicz, 2016/01/07 00:44:53]

Right.  Although in this case I am surprised by the forward declaration added
here - url/url_canon.h includes the full declaration and it is included above
(on line 16).

[Nico, 2016/01/08 00:34:26]

I think in general iwyu doesn't work super well – that's why we don't use it
much.

(We used to have a wiki page for it
https://code.google.com/p/chromium/source/browse/wiki/IncludeWhatYouUse.wiki?...
but it never was really ready for chromium so we didn't look at it much)

[Łukasz Anforowicz, 2016/01/08 17:26:41]

Thanks for the reference - I've added the link to crbug.com/259043.

+
 // Represents a URL.
 //
 // A parsed canonicalized URL will be guaranteed UTF-8. Only the ref (if
 // specified) can be non-ASCII, the host, path, etc. will be guaranteed ASCII
 // and any non-ASCII characters will be encoded and % escaped.
 //
 // The string representation of a URL is called the spec(). Getting the
 // spec will assert if the URL is invalid to help protect against malicious
 // URLs. If you want the "best effort" canonicalization of an invalid URL, you
 // can use possibly_invalid_spec(). Test validity with is_valid(). Data and
@@ skipping 401 matching lines @@
   url::Parsed parsed_;
 
   // Used for nested schemes [currently only filesystem:].
   scoped_ptr<GURL> inner_url_;
 };
 
 // Stream operator so GURL can be used in assertion statements.
 URL_EXPORT std::ostream& operator<<(std::ostream& out, const GURL& url);
 
 #endif  // URL_GURL_H_