IWYU fixes for url/...

url/url_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "url/url_util.h"
 
 #include <stddef.h>
 #include <string.h>
-#include <vector>
+#include <debug/vector>

[Łukasz Anforowicz, 2016/01/07 00:16:17]

I have no idea why IWYU thought that changing <vector> to <debug/vector> might
be a good idea...  I was building Debug flavor FWIW...

This is what iwyu.out said:
  ../../url/url_util.cc should add these lines:
  #include <debug/vector>                         // for vector

  ../../url/url_util.cc should remove these lines:
  - #include <vector>  // lines 10-10

Maybe this is happening because I built a debug flavor of clang/iwyu tool?

+#include <ostream>

[Łukasz Anforowicz, 2016/01/07 00:16:17]

I don't know why <ostream> is needed.  We do use << for streaming into a DCHECK
macro below, but 1) this should be covered by including base/logging.h + 2) we
don't use any stream-related classes.

FWIW, iwyu.out says:
  #include <ostream>  // for operator<<

 
 #include "base/debug/leak_annotations.h"
 #include "base/logging.h"
+#include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
+#include "url/third_party/mozilla/url_parse.h"
 #include "url/url_canon_internal.h"
-#include "url/url_file.h"
-#include "url/url_util_internal.h"
+#include "url/url_constants.h"
+#include "url/url_parse_internal.h"
 
 namespace url {
 
 namespace {
 
 const int kNumStandardURLSchemes = 8;
 const SchemeWithType kStandardURLSchemes[kNumStandardURLSchemes] = {
   {kHttpScheme, SCHEME_WITH_PORT},
   {kHttpsScheme, SCHEME_WITH_PORT},
   // Yes, file URLs can have a hostname, so file URLs should be handled as
@@ skipping 548 matching lines @@
   return DoCompareSchemeComponent(spec, component, compare_to);
 }
 
 bool CompareSchemeComponent(const base::char16* spec,
                             const Component& component,
                             const char* compare_to) {
   return DoCompareSchemeComponent(spec, component, compare_to);
 }
 
 }  // namespace url