IWYU fixes for url/...

url/url_canon_internal.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef URL_URL_CANON_INTERNAL_H_
 #define URL_URL_CANON_INTERNAL_H_
 
 // This file is intended to be included in another C++ file where the character
 // types are defined. This allows us to write mostly generic code, but not have
 // template bloat because everything is inlined when anybody calls any of our
 // functions.
 
 #include <stddef.h>
 #include <stdlib.h>
 
 #include "base/logging.h"
+#include "base/strings/string16.h"
 #include "url/url_canon.h"
+#include "url/url_export.h"
 
 namespace url {
 
 // Character type handling -----------------------------------------------------
 
 // Bits that identify different character types. These types identify different
 // bits that are set for each 8-bit character in the kSharedCharTypeTable.
+struct Component;

[Łukasz Anforowicz, 2016/01/07 00:16:17]

Good catch by the IWYU tool - a "const Component&" is indeed used by a few
functions below and so a fwd decl is needed in absence of include of
url/third_party/mozilla/url_parse.h (which has the full declaration of the
Component struct).

OTOH, the fwd declaration inserted by IWYU is incorrectly separating a comment
(above) from the enum it applies to (below)...

+struct Parsed;
+
 enum SharedCharTypes {
   // Characters that do not require escaping in queries. Characters that do
   // not have this flag will be escaped; see url_canon_query.cc
   CHAR_QUERY = 1,
 
   // Valid in the username/password field.
   CHAR_USERINFO = 2,
 
   // Valid in a IPv4 address (digits plus dot and 'x' for hex).
   CHAR_IPV4 = 4,
@@ skipping 390 matching lines @@
 inline unsigned long long _strtoui64(const char* nptr,
                                      char** endptr, int base) {
   return strtoull(nptr, endptr, base);
 }
 
 #endif  // WIN32
 
 }  // namespace url
 
 #endif  // URL_URL_CANON_INTERNAL_H_