Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: tests/CPlusPlusEleven.cpp

Issue 1561683002: Start using <type_traits> and <utility> (C++11). (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2015 Google Inc. 2 * Copyright 2015 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 #include "Test.h" 7 #include "Test.h"
8 #include "SkTemplates.h" 8 #include "SkTemplates.h"
9 9
10 #include <utility>
11
10 namespace { 12 namespace {
11 class Moveable { 13 class Moveable {
12 public: 14 public:
13 Moveable() {} 15 Moveable() {}
14 Moveable(Moveable&&) {} 16 Moveable(Moveable&&) {}
15 Moveable& operator=(Moveable&&) { return *this; } 17 Moveable& operator=(Moveable&&) { return *this; }
16 private: 18 private:
17 Moveable(const Moveable&); 19 Moveable(const Moveable&);
18 Moveable& operator=(const Moveable&); 20 Moveable& operator=(const Moveable&);
19 }; 21 };
20 template <typename T> void deleter(T*) { } 22 template <typename T> void deleter(T*) { }
21 template <typename T> struct Deleter { 23 template <typename T> struct Deleter {
22 void operator()(T* t) { delete static_cast<const Moveable*>(t); } 24 void operator()(T* t) { delete static_cast<const Moveable*>(t); }
23 }; 25 };
24 } // namespace 26 } // namespace
25 27
26 DEF_TEST(CPlusPlusEleven_RvalueAndMove, r) { 28 DEF_TEST(CPlusPlusEleven_RvalueAndMove, r) {
27 Moveable src1; Moveable dst1(skstd::move(src1)); 29 Moveable src1; Moveable dst1(std::move(src1));
28 Moveable src2, dst2; dst2 = skstd::move(src2); 30 Moveable src2, dst2; dst2 = std::move(src2);
29 } 31 }
30 32
31 #define TOO_BIG "The unique_ptr was bigger than expected." 33 #define TOO_BIG "The unique_ptr was bigger than expected."
32 #define WEIRD_SIZE "The unique_ptr was a different size than expected." 34 #define WEIRD_SIZE "The unique_ptr was a different size than expected."
33 35
34 DEF_TEST(CPlusPlusEleven_UniquePtr, r) { 36 DEF_TEST(CPlusPlusEleven_UniquePtr, r) {
35 struct SmallUniquePtr { 37 struct SmallUniquePtr {
36 Moveable* p; 38 Moveable* p;
37 }; 39 };
38 struct BigUniquePtr { 40 struct BigUniquePtr {
39 void(*d)(Moveable*); 41 void(*d)(Moveable*);
40 Moveable* p; 42 Moveable* p;
41 }; 43 };
42 44
43 static_assert(sizeof(skstd::unique_ptr<Moveable>) == sizeof(SmallUniquePtr), TOO_BIG); 45 static_assert(sizeof(skstd::unique_ptr<Moveable>) == sizeof(SmallUniquePtr), TOO_BIG);
44 static_assert(sizeof(skstd::unique_ptr<Moveable[]>) == sizeof(SmallUniquePtr ), TOO_BIG); 46 static_assert(sizeof(skstd::unique_ptr<Moveable[]>) == sizeof(SmallUniquePtr ), TOO_BIG);
45 47
46 using proc = void(*)(Moveable*); 48 using proc = void(*)(Moveable*);
47 static_assert(sizeof(skstd::unique_ptr<Moveable, proc>) == sizeof(BigUniqueP tr), WEIRD_SIZE); 49 static_assert(sizeof(skstd::unique_ptr<Moveable, proc>) == sizeof(BigUniqueP tr), WEIRD_SIZE);
48 static_assert(sizeof(skstd::unique_ptr<Moveable[], proc>) == sizeof(BigUniqu ePtr), WEIRD_SIZE); 50 static_assert(sizeof(skstd::unique_ptr<Moveable[], proc>) == sizeof(BigUniqu ePtr), WEIRD_SIZE);
49 51
50 { 52 {
51 skstd::unique_ptr<Moveable, void(*)(Moveable*)> u(nullptr, deleter<Movea ble>); 53 skstd::unique_ptr<Moveable, void(*)(Moveable*)> u(nullptr, deleter<Movea ble>);
52 static_assert(sizeof(u) == sizeof(BigUniquePtr), WEIRD_SIZE); 54 static_assert(sizeof(u) == sizeof(BigUniquePtr), WEIRD_SIZE);
53 55
54 auto u2 = skstd::move(u); 56 auto u2 = std::move(u);
55 static_assert(sizeof(u2) == sizeof(BigUniquePtr), WEIRD_SIZE); 57 static_assert(sizeof(u2) == sizeof(BigUniquePtr), WEIRD_SIZE);
56 } 58 }
57 59
58 { 60 {
59 skstd::unique_ptr<Moveable, void(*)(Moveable*)> u(nullptr, [](Moveable* m){ deleter(m); }); 61 skstd::unique_ptr<Moveable, void(*)(Moveable*)> u(nullptr, [](Moveable* m){ deleter(m); });
60 static_assert(sizeof(u) == sizeof(BigUniquePtr), WEIRD_SIZE); 62 static_assert(sizeof(u) == sizeof(BigUniquePtr), WEIRD_SIZE);
61 63
62 auto u2 = skstd::move(u); 64 auto u2 = std::move(u);
63 static_assert(sizeof(u2) == sizeof(BigUniquePtr), WEIRD_SIZE); 65 static_assert(sizeof(u2) == sizeof(BigUniquePtr), WEIRD_SIZE);
64 } 66 }
65 67
66 { 68 {
67 auto d = [](Moveable* m){ deleter(m); }; 69 auto d = [](Moveable* m){ deleter(m); };
68 skstd::unique_ptr<Moveable, decltype(d)> u(nullptr, d); 70 skstd::unique_ptr<Moveable, decltype(d)> u(nullptr, d);
69 static_assert(sizeof(u) == sizeof(SmallUniquePtr), TOO_BIG); 71 static_assert(sizeof(u) == sizeof(SmallUniquePtr), TOO_BIG);
70 72
71 auto u2 = skstd::move(u); 73 auto u2 = std::move(u);
72 static_assert(sizeof(u2) == sizeof(SmallUniquePtr), TOO_BIG); 74 static_assert(sizeof(u2) == sizeof(SmallUniquePtr), TOO_BIG);
73 } 75 }
74 76
75 { 77 {
76 skstd::unique_ptr<Moveable, Deleter<Moveable>> u(nullptr, Deleter<Moveab le>()); 78 skstd::unique_ptr<Moveable, Deleter<Moveable>> u(nullptr, Deleter<Moveab le>());
77 static_assert(sizeof(u) == sizeof(SmallUniquePtr), TOO_BIG); 79 static_assert(sizeof(u) == sizeof(SmallUniquePtr), TOO_BIG);
78 80
79 auto u2 = skstd::move(u); 81 auto u2 = std::move(u);
80 static_assert(sizeof(u2) == sizeof(SmallUniquePtr), TOO_BIG); 82 static_assert(sizeof(u2) == sizeof(SmallUniquePtr), TOO_BIG);
81 } 83 }
82 84
83 { 85 {
84 skstd::unique_ptr<Moveable, Deleter<Moveable>> u(new Moveable(), Deleter <Moveable>()); 86 skstd::unique_ptr<Moveable, Deleter<Moveable>> u(new Moveable(), Deleter <Moveable>());
85 static_assert(sizeof(u) == sizeof(SmallUniquePtr), TOO_BIG); 87 static_assert(sizeof(u) == sizeof(SmallUniquePtr), TOO_BIG);
86 88
87 auto u2 = skstd::move(u); 89 auto u2 = std::move(u);
88 static_assert(sizeof(u2) == sizeof(SmallUniquePtr), TOO_BIG); 90 static_assert(sizeof(u2) == sizeof(SmallUniquePtr), TOO_BIG);
89 } 91 }
90 92
91 { 93 {
92 skstd::unique_ptr<const void, Deleter<const void>> u(new Moveable(), Del eter<const void>()); 94 skstd::unique_ptr<const void, Deleter<const void>> u(new Moveable(), Del eter<const void>());
93 static_assert(sizeof(u) == sizeof(SmallUniquePtr), TOO_BIG); 95 static_assert(sizeof(u) == sizeof(SmallUniquePtr), TOO_BIG);
94 96
95 auto u2 = skstd::move(u); 97 auto u2 = std::move(u);
96 static_assert(sizeof(u2) == sizeof(SmallUniquePtr), TOO_BIG); 98 static_assert(sizeof(u2) == sizeof(SmallUniquePtr), TOO_BIG);
97 } 99 }
98 } 100 }
OLDNEW
« src/utils/SkTFitsIn.h ('K') | « src/utils/SkTFitsIn.h ('k') | tools/BUILD.public.expected » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698