Start using <type_traits> and <utility> (C++11).

Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.

Committed: https://skia.googlesource.com/skia/+/221524de3be1fc343ad328c5e99562f32b5cad9c

[bungeman-skia, 2016-01-05 18:40:48]

Description was changed from

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.
==========

to

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-01-05 18:41:22]

Description was changed from

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.
==========

[bungeman-skia, 2016-01-05 18:54:43]

https://codereview.chromium.org/1561683002/diff/1/include/private/SkUniquePtr.h
File include/private/SkUniquePtr.h (right):

https://codereview.chromium.org/1561683002/diff/1/include/private/SkUniquePtr...
include/private/SkUniquePtr.h:99: /*constexpr*/ unique_ptr(std::nullptr_t)
/*noexcept*/ : unique_ptr() { }
std::nullptr_t is provided by <cstddef>

https://codereview.chromium.org/1561683002/diff/1/src/core/SkFindAndPlaceGlyph.h
File src/core/SkFindAndPlaceGlyph.h (right):

https://codereview.chromium.org/1561683002/diff/1/src/core/SkFindAndPlaceGlyp...
src/core/SkFindAndPlaceGlyph.h:17: 
need <utility>

https://codereview.chromium.org/1561683002/diff/1/src/gpu/effects/GrPorterDuf...
File src/gpu/effects/GrPorterDuffXferProcessor.cpp (right):

https://codereview.chromium.org/1561683002/diff/1/src/gpu/effects/GrPorterDuf...
src/gpu/effects/GrPorterDuffXferProcessor.cpp:22: 
need <utility>

https://codereview.chromium.org/1561683002/diff/1/src/utils/SkTFitsIn.h
File src/utils/SkTFitsIn.h (right):

https://codereview.chromium.org/1561683002/diff/1/src/utils/SkTFitsIn.h#newco...
src/utils/SkTFitsIn.h:14: 
need <type_traits>

[mtklein, 2016-01-05 18:56:08]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-01-05 18:56:08]

lgtm lgtm lgtm lgtm!!!

[bungeman-skia, 2016-01-05 18:58:02]

Description was changed from

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.
==========

to

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-01-05 18:58:21]

Description was changed from

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.
==========

[bungeman-skia, 2016-01-05 18:59:41]

https://codereview.chromium.org/1561683002/diff/1/include/private/SkUniquePtr.h
File include/private/SkUniquePtr.h (right):

https://codereview.chromium.org/1561683002/diff/1/include/private/SkUniquePtr...
include/private/SkUniquePtr.h:99: /*constexpr*/ unique_ptr(std::nullptr_t)
/*noexcept*/ : unique_ptr() { }
On 2016/01/05 18:54:43, bungeman1 wrote:
> std::nullptr_t is provided by <cstddef>

Done.

https://codereview.chromium.org/1561683002/diff/1/src/core/SkFindAndPlaceGlyph.h
File src/core/SkFindAndPlaceGlyph.h (right):

https://codereview.chromium.org/1561683002/diff/1/src/core/SkFindAndPlaceGlyp...
src/core/SkFindAndPlaceGlyph.h:17: 
On 2016/01/05 18:54:43, bungeman1 wrote:
> need <utility>

Done.

https://codereview.chromium.org/1561683002/diff/1/src/gpu/effects/GrPorterDuf...
File src/gpu/effects/GrPorterDuffXferProcessor.cpp (right):

https://codereview.chromium.org/1561683002/diff/1/src/gpu/effects/GrPorterDuf...
src/gpu/effects/GrPorterDuffXferProcessor.cpp:22: 
On 2016/01/05 18:54:43, bungeman1 wrote:
> need <utility>

Done.

https://codereview.chromium.org/1561683002/diff/1/src/utils/SkTFitsIn.h
File src/utils/SkTFitsIn.h (right):

https://codereview.chromium.org/1561683002/diff/1/src/utils/SkTFitsIn.h#newco...
src/utils/SkTFitsIn.h:14: 
On 2016/01/05 18:54:43, bungeman1 wrote:
> need <type_traits>

Done.

[bungeman-skia, 2016-01-05 18:59:53]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-05 18:59:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1561683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1561683002/20001

[commit-bot: I haz the power, 2016-01-05 19:02:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-05 19:02:23]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[reed1, 2016-01-05 20:17:48]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-01-05 20:17:49]

I need a book/tutorial

lgtm

[bungeman-skia, 2016-01-05 21:26:08]

I can reproduce the vc++12 issue (with vs2013). Of course with vc++14 (vs2015)
everything works fine. I'm not sure what the exact issue is yet.

[bungeman-skia, 2016-01-05 22:34:01]

Description was changed from

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.
==========

to

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-01-05 22:34:17]

Description was changed from

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.
==========

[bungeman-skia, 2016-01-05 22:34:28]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-05 22:34:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1561683002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1561683002/40001

[commit-bot: I haz the power, 2016-01-05 22:50:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-05 22:50:53]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-01-05 22:56:53]

I dunno, even if you've read the book/tutorial there a subtle things like
this...

https://codereview.chromium.org/1561683002/diff/20001/include/private/SkUniqu...
File include/private/SkUniquePtr.h (right):

https://codereview.chromium.org/1561683002/diff/20001/include/private/SkUniqu...
include/private/SkUniquePtr.h:55: /*constexpr*/ compressed_base(const B&& b) :
B(std::move(b)) {}
What vc++12 (vs2013) is complaining about is that the type of 'std::move(const
SkTUnref<T>&)' is 'const SkTUnref<T>&&', but the generated move constructor
signature is 'SkTUnref<T>(SkTUnref<T>&&)'. I think this is actually a bug, in
that I think the current way this is written implies calling the copy
constructor of B instead of the move constructor. This should be fixed, and
doing so makes vc++12 happy.

On the other hand, I still don't know the difference between the old code and
the new code which caused vc++12 to start complaining. Everything looks very
similar. vc++14 accepting this appears to be a result of full implementation of
'Rvalue References v3.0'.

[bungeman-skia, 2016-01-05 22:58:40]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2016-01-05 22:58:41]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1561683002/#ps40001
(title: "Fix skstd::unique_ptr::compressed_pair.")

[commit-bot: I haz the power, 2016-01-05 22:58:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1561683002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1561683002/40001

[commit-bot: I haz the power, 2016-01-05 22:59:43]

Description was changed from

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.
==========

to

==========
Start using <type_traits> and <utility> (C++11).

SkUtility.h and SkTLogic.h implement a number of type traits now
available through <type_traits> and <utility>. This removes SkUtility.h,
replacing it with <utility>, and moves a number of traits in
SkTLogic.h to use the std:: equivelents. This change only uses C++11
parts of the standard library; SkTLogic.h will continue to provide
C++14 and beyond for now in the skstd namespace.

The changes to SkTLogic.h are being done gradually so that safe changes
may be landed confidently, with more risky changes in the future.

Committed:
https://skia.googlesource.com/skia/+/221524de3be1fc343ad328c5e99562f32b5cad9c
==========

[commit-bot: I haz the power, 2016-01-05 22:59:44]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/221524de3be1fc343ad328c5e99562f32b5cad9c