Use long for times and timestamps throught Java cast code

Use long for times and timestamps throught Java cast code

This prevents overflows that could occur if a phone was left on for
more than 2^31ms (roughly 23 days). The overflows caused various
strange behaviour with pausing and seeking.

BUG=574433
Committed: https://crrev.com/a73c6eafbb1d11c382edef8c5c8cadc7a7dd04c2
Cr-Commit-Position: refs/heads/master@{#367815}

[aberent, 2016-01-05 18:42:14]

Description was changed from

==========
Use long for times and timestamps throught Java cast code

This prevents overflows that could occur if a phone was left on for
more than 2^31ms (roughly 23 days). The overflows caused various
strange behaviour with pausing and seeking.

BUG=574443
==========

to

==========
Use long for times and timestamps throught Java cast code

This prevents overflows that could occur if a phone was left on for
more than 2^31ms (roughly 23 days). The overflows caused various
strange behaviour with pausing and seeking.

BUG=574433
==========

[aberent, 2016-01-05 18:47:43]

aberent@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2016-01-05 21:19:24]

lgtm % comments

https://codereview.chromium.org/1561663002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteController.java
(right):

https://codereview.chromium.org/1561663002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteController.java:161:
private static final int END_OF_VIDEO_THRESHOLD_MS = 500;
Shouldn't this be a long as well?

https://codereview.chromium.org/1561663002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/remote/NotificationTransportControl.java
(right):

https://codereview.chromium.org/1561663002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/remote/NotificationTransportControl.java:188:
contentView.setProgressBar(R.id.progress, (int) videoInfo.durationMillis,
is this typecast a potential problem for really long videos?

[aberent, 2016-01-06 11:13:34]

https://codereview.chromium.org/1561663002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteController.java
(right):

https://codereview.chromium.org/1561663002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteController.java:161:
private static final int END_OF_VIDEO_THRESHOLD_MS = 500;
On 2016/01/05 21:19:24, whywhat wrote:
> Shouldn't this be a long as well?

Done.

https://codereview.chromium.org/1561663002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/remote/NotificationTransportControl.java
(right):

https://codereview.chromium.org/1561663002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/remote/NotificationTransportControl.java:188:
contentView.setProgressBar(R.id.progress, (int) videoInfo.durationMillis,
On 2016/01/05 21:19:24, whywhat wrote:
> is this typecast a potential problem for really long videos?

Done (although I think you will have trouble finding a video that exercises
this).

[aberent, 2016-01-06 11:18:20]

The CQ bit was checked by aberent@chromium.org

[aberent, 2016-01-06 11:18:21]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/1561663002/#ps20001
(title: "Fix nits")

[commit-bot: I haz the power, 2016-01-06 11:18:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1561663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1561663002/20001

[commit-bot: I haz the power, 2016-01-06 12:00:16]

Description was changed from

==========
Use long for times and timestamps throught Java cast code

This prevents overflows that could occur if a phone was left on for
more than 2^31ms (roughly 23 days). The overflows caused various
strange behaviour with pausing and seeking.

BUG=574433
==========

to

==========
Use long for times and timestamps throught Java cast code

This prevents overflows that could occur if a phone was left on for
more than 2^31ms (roughly 23 days). The overflows caused various
strange behaviour with pausing and seeking.

BUG=574433
==========

[commit-bot: I haz the power, 2016-01-06 12:00:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-06 12:01:40]

Description was changed from

==========
Use long for times and timestamps throught Java cast code

This prevents overflows that could occur if a phone was left on for
more than 2^31ms (roughly 23 days). The overflows caused various
strange behaviour with pausing and seeking.

BUG=574433
==========

to

==========
Use long for times and timestamps throught Java cast code

This prevents overflows that could occur if a phone was left on for
more than 2^31ms (roughly 23 days). The overflows caused various
strange behaviour with pausing and seeking.

BUG=574433

Committed: https://crrev.com/a73c6eafbb1d11c382edef8c5c8cadc7a7dd04c2
Cr-Commit-Position: refs/heads/master@{#367815}
==========

[commit-bot: I haz the power, 2016-01-06 12:01:41]

Patchset 2 (id:??) landed as
https://crrev.com/a73c6eafbb1d11c382edef8c5c8cadc7a7dd04c2
Cr-Commit-Position: refs/heads/master@{#367815}