Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1561633002: Relocate ShapeResult's GlyphBuffer helpers to ShapeResultBuffer (Closed)

Created:
4 years, 11 months ago by f(malita)
Modified:
4 years, 11 months ago
Reviewers:
drott, eae
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, danakj, Rik, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relocate ShapeResult's GlyphBuffer helpers to ShapeResultBuffer Follow-up to http://crrev.com/1557743002: the GlyphBuffer builders now operate on ShapeResultBuffers, so it makes sense to implement as methods. Code shuffling - no functional changes. R=eae@chromium.org,drott@chromium.org Committed: https://crrev.com/562fe4a4f4147fc4fe480b18a804289171fa5baf Cr-Commit-Position: refs/heads/master@{#367658}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -694 lines) Patch
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp View 5 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h View 4 chunks +9 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp View 1 3 chunks +1 line, -365 lines 0 comments Download
A third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h View 1 chunk +57 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp View 1 11 chunks +86 lines, -267 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
f(malita)
4 years, 11 months ago (2016-01-05 18:47:28 UTC) #4
eae
LGTM
4 years, 11 months ago (2016-01-05 18:58:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561633002/20001
4 years, 11 months ago (2016-01-05 19:00:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/155063)
4 years, 11 months ago (2016-01-05 20:35:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561633002/20001
4 years, 11 months ago (2016-01-05 20:37:58 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-05 21:59:38 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 22:00:31 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/562fe4a4f4147fc4fe480b18a804289171fa5baf
Cr-Commit-Position: refs/heads/master@{#367658}

Powered by Google App Engine
This is Rietveld 408576698