Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1561603002: [Interpreted] Throws an error if rest parameters are used. (Closed)

Created:
4 years, 11 months ago by mythria
Modified:
4 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreted] Throws an error if rest parameters are used. Throws an error if rest parameters are used. This feature is not yet supported in interpreter. BUG=v8:4280 LOG=N Committed: https://crrev.com/3efce1c77e63ae3690cbd25de861e0273ed015f8 Cr-Commit-Position: refs/heads/master@{#33120}

Patch Set 1 #

Patch Set 2 : Skips a failing test262 test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mythria
PTAL thanks, mythri
4 years, 11 months ago (2016-01-05 15:35:00 UTC) #2
rmcilroy
LGTM.
4 years, 11 months ago (2016-01-05 15:36:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561603002/20001
4 years, 11 months ago (2016-01-05 17:02:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-05 17:03:34 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 17:04:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3efce1c77e63ae3690cbd25de861e0273ed015f8
Cr-Commit-Position: refs/heads/master@{#33120}

Powered by Google App Engine
This is Rietveld 408576698