Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1561563002: Cleanup ResourceDispatcher::PendingRequestInfo (Closed)

Created:
4 years, 11 months ago by kinuko
Modified:
4 years, 11 months ago
Reviewers:
yhirano
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup ResourceDispatcher::PendingRequestInfo Some preliminary cleanups for RequestPeer lifetime fix. - Changes hash_map<> to map<scoped_ptr<>>, remove default ctor - Replaces some linked_ptr with scoped_ptr (crbug.com/556939) BUG=507170, 556939 Committed: https://crrev.com/b946dc7afe1ad7a11a423d1519ad4f880b62a44c Cr-Commit-Position: refs/heads/master@{#367782}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -64 lines) Patch
M content/child/resource_dispatcher.h View 5 chunks +9 lines, -10 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 12 chunks +27 lines, -40 lines 0 comments Download
M content/child/site_isolation_stats_gatherer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/site_isolation_stats_gatherer.cc View 6 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kinuko
PTL
4 years, 11 months ago (2016-01-05 14:06:05 UTC) #3
yhirano
LGTM https://codereview.chromium.org/1561563002/diff/1/content/child/resource_dispatcher.cc File content/child/resource_dispatcher.cc (right): https://codereview.chromium.org/1561563002/diff/1/content/child/resource_dispatcher.cc#newcode458 content/child/resource_dispatcher.cc:458: const PendingRequestInfo& info = *it->second.get(); Is ".get()" needed?
4 years, 11 months ago (2016-01-06 04:07:48 UTC) #4
kinuko
Thanks! https://codereview.chromium.org/1561563002/diff/1/content/child/resource_dispatcher.cc File content/child/resource_dispatcher.cc (right): https://codereview.chromium.org/1561563002/diff/1/content/child/resource_dispatcher.cc#newcode458 content/child/resource_dispatcher.cc:458: const PendingRequestInfo& info = *it->second.get(); On 2016/01/06 04:07:48, ...
4 years, 11 months ago (2016-01-06 04:18:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561563002/20001
4 years, 11 months ago (2016-01-06 04:19:01 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-06 05:33:25 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 05:34:11 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b946dc7afe1ad7a11a423d1519ad4f880b62a44c
Cr-Commit-Position: refs/heads/master@{#367782}

Powered by Google App Engine
This is Rietveld 408576698