Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1561483004: Correctly propagate end value for exponential ramp (Closed)

Created:
4 years, 11 months ago by Raymond Toy
Modified:
4 years, 11 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly propagate end value for exponential ramp When the start and end values of an exponential ramp have opposite signs, the exponential ramp should propagate the start value. Previously, it would, until the end of the exponential ramp where the output would jump to the specified end value of the ramp. BUG=574529 TEST=audioparam-negative-exponentialRamp.html updated with test. Committed: https://crrev.com/efe8e531bbf3e7a2fa7ca82fb46d208cad9fe6cf Cr-Commit-Position: refs/heads/master@{#369228}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/audioparam-negative-exponentialRamp.html View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/audioparam-negative-exponentialRamp-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp View 1 2 4 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Raymond Toy
PTAL.
4 years, 11 months ago (2016-01-06 22:03:39 UTC) #2
Raymond Toy
https://codereview.chromium.org/1561483004/diff/20001/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp File third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp (left): https://codereview.chromium.org/1561483004/diff/20001/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp#oldcode417 third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp:417: I think this is actually incorrect and was just ...
4 years, 11 months ago (2016-01-06 22:05:02 UTC) #3
Raymond Toy
Ping.
4 years, 11 months ago (2016-01-13 17:36:08 UTC) #4
hongchan
lgtm
4 years, 11 months ago (2016-01-13 17:39:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561483004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561483004/40001
4 years, 11 months ago (2016-01-13 17:44:16 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-13 19:00:16 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 19:01:04 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/efe8e531bbf3e7a2fa7ca82fb46d208cad9fe6cf
Cr-Commit-Position: refs/heads/master@{#369228}

Powered by Google App Engine
This is Rietveld 408576698