Add ability to get raw data and range requests to to PrivetURLFetcher

Add ability to get raw data and range requests to to PrivetURLFetcher

Add ability to read data without parsing it as JSON to PrivetURLFetcher. In
addition, add the ability to send range requests.

BUG=332182
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250846

[Vitaly Buka (NO REVIEWS), 2014-02-06 01:07:11]

On 2014/02/05 22:10:29, Noam Samuel wrote:

please update patch

[Vitaly Buka (NO REVIEWS), 2014-02-07 19:47:39]

lgtm

https://codereview.chromium.org/156143002/diff/90001/chrome/browser/local_dis...
File chrome/browser/local_discovery/privet_url_fetcher.cc (right):

https://codereview.chromium.org/156143002/diff/90001/chrome/browser/local_dis...
chrome/browser/local_discovery/privet_url_fetcher.cc:31: DCHECK(start >= 0);
DCHECK_GT?

https://codereview.chromium.org/156143002/diff/90001/chrome/browser/local_dis...
chrome/browser/local_discovery/privet_url_fetcher.cc:51: :
privet_access_token_(token), url_(url), request_type_(request_type),
one per line might be more readable.

https://codereview.chromium.org/156143002/diff/90001/chrome/browser/local_dis...
chrome/browser/local_discovery/privet_url_fetcher.cc:54:
do_not_parse_data_(false), has_byte_range_(false),
probably do_not_parse_data_ is depends on delegate
so maybe get this from delegate?

https://codereview.chromium.org/156143002/diff/90001/chrome/browser/local_dis...
File chrome/browser/local_discovery/privet_url_fetcher.h (right):

https://codereview.chromium.org/156143002/diff/90001/chrome/browser/local_dis...
chrome/browser/local_discovery/privet_url_fetcher.h:10: #include
"base/file_util.h"
one should be enough

[commit-bot: I haz the power, 2014-02-07 19:49:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/156143002/90001

[commit-bot: I haz the power, 2014-02-07 22:19:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/156143002/90001

[Vitaly Buka (NO REVIEWS), 2014-02-07 22:24:33]

The CQ bit was unchecked by vitalybuka@chromium.org

[Noam Samuel, 2014-02-12 20:25:15]

https://codereview.chromium.org/156143002/diff/90001/chrome/browser/local_dis...
File chrome/browser/local_discovery/privet_url_fetcher.cc (right):

https://codereview.chromium.org/156143002/diff/90001/chrome/browser/local_dis...
chrome/browser/local_discovery/privet_url_fetcher.cc:31: DCHECK(start >= 0);
On 2014/02/07 19:47:39, Vitaly Buka wrote:
> DCHECK_GT?

Done.

https://codereview.chromium.org/156143002/diff/90001/chrome/browser/local_dis...
chrome/browser/local_discovery/privet_url_fetcher.cc:51: :
privet_access_token_(token), url_(url), request_type_(request_type),
On 2014/02/07 19:47:39, Vitaly Buka wrote:
> one per line might be more readable.

Done.

https://codereview.chromium.org/156143002/diff/90001/chrome/browser/local_dis...
chrome/browser/local_discovery/privet_url_fetcher.cc:54:
do_not_parse_data_(false), has_byte_range_(false),
On 2014/02/07 19:47:39, Vitaly Buka wrote:
> probably do_not_parse_data_ is depends on delegate
> so maybe get this from delegate?

Done.

https://codereview.chromium.org/156143002/diff/90001/chrome/browser/local_dis...
File chrome/browser/local_discovery/privet_url_fetcher.h (right):

https://codereview.chromium.org/156143002/diff/90001/chrome/browser/local_dis...
chrome/browser/local_discovery/privet_url_fetcher.h:10: #include
"base/file_util.h"
On 2014/02/07 19:47:39, Vitaly Buka wrote:
> one should be enough

Done.

[Vitaly Buka (NO REVIEWS), 2014-02-12 20:34:30]

lgtm

[commit-bot: I haz the power, 2014-02-12 20:34:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/156143002/370001

[commit-bot: I haz the power, 2014-02-12 23:45:56]

Change committed as 250846