Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1561413003: Reland: Settings People Revamp: Implement Chrome Profile name/icon selection (Closed)

Created:
4 years, 11 months ago by tommycli
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Settings People Revamp: Implement Chrome Profile name/icon selection Original landing broke Closure bot due to strange git merge. BUG=563721 TBR= Committed: https://crrev.com/d1838b51461704048765d1f2d26fd5e970427af6 Cr-Commit-Position: refs/heads/master@{#368214}

Patch Set 1 #

Patch Set 2 : Rebase to remove redundant changes already put in by a separate CL. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -475 lines) Patch
M chrome/app/settings_strings.grdp View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + chrome/browser/resources/settings/people_page/manage_profile.css View 1 chunk +7 lines, -3 lines 0 comments Download
A chrome/browser/resources/settings/people_page/manage_profile.html View 1 chunk +26 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/people_page/manage_profile.js View 1 chunk +96 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 3 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.js View 2 chunks +33 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/sync_private_api.js View 3 chunks +52 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/compiled_resources.gyp View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_router.js View 1 3 chunks +17 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 3 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.h View 4 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.cc View 5 chunks +30 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler_unittest.cc View 15 chunks +29 lines, -20 lines 0 comments Download
A + chrome/browser/ui/webui/settings/settings_manage_profile_handler.h View 4 chunks +18 lines, -72 lines 0 comments Download
A + chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc View 13 chunks +40 lines, -360 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561413003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561413003/40001
4 years, 11 months ago (2016-01-07 23:38:40 UTC) #3
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-08 00:27:29 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 00:29:14 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d1838b51461704048765d1f2d26fd5e970427af6
Cr-Commit-Position: refs/heads/master@{#368214}

Powered by Google App Engine
This is Rietveld 408576698