Issue 1561383002: relnote: add new unused functions for client side of QUIC server push.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1561383002: relnote: add new unused functions for client side of QUIC server push. (Closed)

Created:
4 years, 11 months ago by Zhongyi Shi

Modified:
4 years, 11 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@21_CL_111427940

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

relnote: add new unused functions for client side of QUIC server push. QUIC - Add helper functions for SpdyHeaderBlock values. Merge internal change: 111439689 BUG=

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : port spdy_utils_test.cc #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+177 lines, -0 lines)			Patch
M	net/net.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/spdy_utils.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	net/quic/spdy_utils.cc	View		2 chunks	+28 lines, -0 lines	0 comments	Download
A	net/quic/spdy_utils_test.cc	View	1 2	1 chunk	+140 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1563083002 Patch 20001

Dependent Patchsets:

Issue 1570553002 Patch 40001

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Zhongyi Shi

Looking at the original cls, we don't have spdy_utils_test.cc in chromium. Any reason that we ...

4 years, 11 months ago (2016-01-07 01:12:03 UTC) #2

Ryan Hamilton

On 2016/01/07 01:12:03, Zhongyi Shi wrote: > Looking at the original cls, we don't have ...

4 years, 11 months ago (2016-01-08 00:08:36 UTC) #3

lgtm

Great!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages