Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1561343002: Updating nacl sdk docs to match changed sample. (Closed)

Created:
4 years, 11 months ago by bradnelson
Modified:
4 years, 11 months ago
Reviewers:
binji, Sam Clegg, bradn
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating nacl sdk docs to match changed sample. The voronoi sample has been reduce to make it easier to maintain. BUG=None TEST=None R=binji@chromium.org,sbc@chromium.org Committed: https://crrev.com/cd21b6ca112d36072b909d88318845b5bfce89e9 Cr-Commit-Position: refs/heads/master@{#370209}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : merge #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -206 lines) Patch
D native_client_sdk/doc_generated/images/voronoi2.png View Binary file 0 comments Download
M native_client_sdk/doc_generated/io2014.html View 5 chunks +8 lines, -98 lines 0 comments Download
D native_client_sdk/src/doc/images/voronoi2.png View Binary file 0 comments Download
M native_client_sdk/src/doc/io2014.rst View 5 chunks +11 lines, -108 lines 1 comment Download

Messages

Total messages: 18 (5 generated)
bradnelson
4 years, 11 months ago (2016-01-06 23:59:34 UTC) #2
Sam Clegg
Why all the pepper_xxx images? Would it be worth putting them in a seperate CL?
4 years, 11 months ago (2016-01-07 00:20:01 UTC) #3
Sam Clegg
Why all the pepper_xxx images? Would it be worth putting them in a separate CL?
4 years, 11 months ago (2016-01-07 00:20:03 UTC) #4
bradn
Something seems to have shuffled. Sending them in a separate change.
4 years, 11 months ago (2016-01-07 00:36:47 UTC) #6
bradn
Reduced. PTAL
4 years, 11 months ago (2016-01-07 01:05:10 UTC) #7
Sam Clegg
https://codereview.chromium.org/1561343002/diff/40001/native_client_sdk/src/doc/io2014.rst File native_client_sdk/src/doc/io2014.rst (right): https://codereview.chromium.org/1561343002/diff/40001/native_client_sdk/src/doc/io2014.rst#newcode100 native_client_sdk/src/doc/io2014.rst:100: So did you update the zip file? Are none ...
4 years, 11 months ago (2016-01-07 01:12:59 UTC) #8
Sam Clegg
On 2016/01/07 01:12:59, Sam Clegg wrote: > https://codereview.chromium.org/1561343002/diff/40001/native_client_sdk/src/doc/io2014.rst > File native_client_sdk/src/doc/io2014.rst (right): > > https://codereview.chromium.org/1561343002/diff/40001/native_client_sdk/src/doc/io2014.rst#newcode100 ...
4 years, 11 months ago (2016-01-07 01:13:31 UTC) #9
bradnelson
I went ahead and updated the zip. The old one just won't work with the ...
4 years, 11 months ago (2016-01-07 19:02:51 UTC) #10
Sam Clegg
lgtm
4 years, 11 months ago (2016-01-19 20:44:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561343002/40001
4 years, 11 months ago (2016-01-19 21:51:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561343002/40001
4 years, 11 months ago (2016-01-19 21:51:51 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-19 22:38:26 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 22:39:58 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cd21b6ca112d36072b909d88318845b5bfce89e9
Cr-Commit-Position: refs/heads/master@{#370209}

Powered by Google App Engine
This is Rietveld 408576698