Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1561283003: Revert of Implement basic USB device enumeration on Android. (Closed)

Created:
4 years, 11 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 11 months ago
Reviewers:
Yaron, qinmin, pfeldman, nasko
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement basic USB device enumeration on Android. (patchset #3 id:40001 of https://codereview.chromium.org/1514603006/ ) Reason for revert: Speculating that this is the cause of issue 575191. Original issue's description: > Implement basic USB device enumeration on Android. > > This patch provides a basic implementation of UsbService::GetDevices on > Android that populates UsbDevice objects by collecting properties of the > Java-side UsbDevice, UsbConfiguration, UsbInterface and UsbEndpoint > objects over JNI. > > It does not support opening devices and does not generate device add or > remove notifications. > > BUG=549257 > > Committed: https://crrev.com/8a310851fb144e91d1777112930ac15c0d88577b > Cr-Commit-Position: refs/heads/master@{#367918} TBR=nasko@chromium.org,qinmin@chromium.org,yfriedman@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=549257, 575191 Committed: https://crrev.com/e3de6dea8003be39328bea275763daab36a8df24 Cr-Commit-Position: refs/heads/master@{#368077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -940 lines) Patch
M chrome/browser/devtools/device/usb/android_usb_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/test/run_all_unittests.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M device/usb/BUILD.gn View 3 chunks +4 lines, -46 lines 0 comments Download
M device/usb/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D device/usb/android/java/src/org/chromium/device/usb/ChromeUsbConfiguration.java View 1 chunk +0 lines, -68 lines 0 comments Download
D device/usb/android/java/src/org/chromium/device/usb/ChromeUsbDevice.java View 1 chunk +0 lines, -84 lines 0 comments Download
D device/usb/android/java/src/org/chromium/device/usb/ChromeUsbEndpoint.java View 1 chunk +0 lines, -83 lines 0 comments Download
D device/usb/android/java/src/org/chromium/device/usb/ChromeUsbInterface.java View 1 chunk +0 lines, -70 lines 0 comments Download
D device/usb/android/java/src/org/chromium/device/usb/ChromeUsbService.java View 1 chunk +0 lines, -45 lines 0 comments Download
D device/usb/android/usb_jni_registrar.h View 1 chunk +0 lines, -22 lines 0 comments Download
D device/usb/android/usb_jni_registrar.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M device/usb/mock_usb_device.h View 2 chunks +3 lines, -2 lines 0 comments Download
M device/usb/usb.gyp View 4 chunks +4 lines, -58 lines 0 comments Download
D device/usb/usb_configuration_android.h View 1 chunk +0 lines, -25 lines 0 comments Download
D device/usb/usb_configuration_android.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M device/usb/usb_descriptors.h View 2 chunks +0 lines, -4 lines 0 comments Download
M device/usb/usb_device.h View 2 chunks +4 lines, -1 line 0 comments Download
D device/usb/usb_device_android.h View 1 chunk +0 lines, -42 lines 0 comments Download
D device/usb/usb_device_android.cc View 1 chunk +0 lines, -107 lines 0 comments Download
M device/usb/usb_device_impl.h View 3 chunks +1 line, -3 lines 0 comments Download
M device/usb/usb_device_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
D device/usb/usb_endpoint_android.h View 1 chunk +0 lines, -25 lines 0 comments Download
D device/usb/usb_endpoint_android.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D device/usb/usb_interface_android.h View 1 chunk +0 lines, -25 lines 0 comments Download
D device/usb/usb_interface_android.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M device/usb/usb_service_android.h View 2 chunks +0 lines, -11 lines 0 comments Download
M device/usb/usb_service_android.cc View 2 chunks +4 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Reilly Grant (use Gerrit)
Created Revert of Implement basic USB device enumeration on Android.
4 years, 11 months ago (2016-01-07 15:14:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561283003/1
4 years, 11 months ago (2016-01-07 15:16:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 15:18:06 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e3de6dea8003be39328bea275763daab36a8df24 Cr-Commit-Position: refs/heads/master@{#368077}
4 years, 11 months ago (2016-01-07 15:19:08 UTC) #8
Reilly Grant (use Gerrit)
4 years, 11 months ago (2016-01-07 20:48:29 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1565313002/ by reillyg@chromium.org.

The reason for reverting is: Lack of GYP dependency on //device/usb Java sources
fixed..

Powered by Google App Engine
This is Rietveld 408576698