Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2456)

Unified Diff: Source/web/tests/FrameTestHelpers.cpp

Issue 156123004: Move the frame tree into the embedder. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: T -> t Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebFrameImpl.cpp ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/FrameTestHelpers.cpp
diff --git a/Source/web/tests/FrameTestHelpers.cpp b/Source/web/tests/FrameTestHelpers.cpp
index 0004cf070b83736610f7b69031367bb9d03e8444..fc25299e7fe7f16e35f3a6ec12d219cdf5d0d5af 100644
--- a/Source/web/tests/FrameTestHelpers.cpp
+++ b/Source/web/tests/FrameTestHelpers.cpp
@@ -147,11 +147,15 @@ void WebViewHelper::reset()
WebFrame* TestWebFrameClient::createChildFrame(WebFrame* parent, const WebString& frameName)
{
- return WebFrame::create(this);
+ WebFrame* frame = WebFrame::create(this);
+ parent->appendChild(frame);
+ return frame;
}
void TestWebFrameClient::frameDetached(WebFrame* frame)
{
+ if (frame->parent())
+ frame->parent()->removeChild(frame);
frame->close();
}
« no previous file with comments | « Source/web/WebFrameImpl.cpp ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698