chrome/browser/extensions/external_component_loader.cc - Issue 15612002: Make sure the google wallet in-app payment support app is always installed.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/external_component_loader.cc

Issue 15612002: Make sure the google wallet in-app payment support app is always installed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change logic to decide which apps to show in chrome://extensions Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/external_component_loader.h ('k') | chrome/browser/extensions/external_provider_impl.cc » ('j') | chrome/common/extensions/extension_constants.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/extensions/external_component_loader.h"

	6

	7 #include "base/values.h"

	8 #include "chrome/common/extensions/extension_constants.h"

	9

	10 namespace extensions {

	11

	12 ExternalComponentLoader::ExternalComponentLoader() {}

	13

	14 void ExternalComponentLoader::StartLoading() {

	15 prefs_.reset(new base::DictionaryValue());

	16 std::string appId = extension_misc::kIAPSupportAppId;

	17 prefs_->SetString(appId + ".name", "Google Wallet Service");
	asargent_no_longer_on_chrome 2013/05/22 00:07:13 Does this string ever get shown to users? If so, d Does this string ever get shown to users? If so, does it need to be localized? If not, can we make it optional (I assume this is just for placeholder until the actual app gets installed from the webstore)? Marijn Kruisselbrink 2013/05/22 21:29:37 It seems this string isn't used at all, I added it Show quoted text On 2013/05/22 00:07:13, Antony Sargent wrote: > Does this string ever get shown to users? If so, does it need to be localized? > If not, can we make it optional (I assume this is just for placeholder until the > actual app gets installed from the webstore)? It seems this string isn't used at all, I added it because it's also there for all the apps in src/chrome/browser/extensions/default_extensions/chromeos/external_extensions.json, but since it isn't actually used afaict I've just removed it.
	18 prefs_->SetString(appId + ".external_update_url",

	19 extension_urls::GetWebstoreUpdateUrl().spec());

	20 LoadFinished();

	21 }

	22

	23 } // namespace extensions

OLD	NEW